fix #3266, Cycled not working without explicit axis

MakieOrg · Oct 4, 2023 · 2b1e9d0 · 2b1e9d0
1 parent bae821a
commit 2b1e9d0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/src/figureplotting.jl b/src/figureplotting.jl
@@ -42,10 +42,8 @@ function plot(P::PlotFunc, args...; axis = NamedTuple(), figure = NamedTuple(),
         ax = axtype(fig; axis...)
     else
         proxyscene = Scene()
-        attrs = Attributes(kw_attributes)
-        delete!(attrs, :show_axis)
-        delete!(attrs, :limits)
-        plot!(proxyscene, P, attrs, args...)
+        # We dont forward the attributes to the plot, since we only need the arguments to determine the axis type
+        plot!(proxyscene, P, Attributes(), args...)
         if is2d(proxyscene)
             ax = Axis(fig; axis...)
         else

diff --git a/src/makielayout/blocks/axis.jl b/src/makielayout/blocks/axis.jl
@@ -781,7 +781,6 @@ function Makie.plot!(
 
     _disallow_keyword(:axis, allattrs)
     _disallow_keyword(:figure, allattrs)
-
     cycle = get_cycle_for_plottype(allattrs, P)
     add_cycle_attributes!(allattrs, P, cycle, la.cycler, la.palette)