From 2b1e9d08bb628c2b520f1625d205ff11137f7733 Mon Sep 17 00:00:00 2001 From: Simon Date: Wed, 4 Oct 2023 15:35:38 +0200 Subject: [PATCH] fix #3266, Cycled not working without explicit axis --- src/figureplotting.jl | 6 ++---- src/makielayout/blocks/axis.jl | 1 - 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/figureplotting.jl b/src/figureplotting.jl index c11b3502a37..647a77c1649 100644 --- a/src/figureplotting.jl +++ b/src/figureplotting.jl @@ -42,10 +42,8 @@ function plot(P::PlotFunc, args...; axis = NamedTuple(), figure = NamedTuple(), ax = axtype(fig; axis...) else proxyscene = Scene() - attrs = Attributes(kw_attributes) - delete!(attrs, :show_axis) - delete!(attrs, :limits) - plot!(proxyscene, P, attrs, args...) + # We dont forward the attributes to the plot, since we only need the arguments to determine the axis type + plot!(proxyscene, P, Attributes(), args...) if is2d(proxyscene) ax = Axis(fig; axis...) else diff --git a/src/makielayout/blocks/axis.jl b/src/makielayout/blocks/axis.jl index 44ecafcf582..1e354ade703 100644 --- a/src/makielayout/blocks/axis.jl +++ b/src/makielayout/blocks/axis.jl @@ -781,7 +781,6 @@ function Makie.plot!( _disallow_keyword(:axis, allattrs) _disallow_keyword(:figure, allattrs) - cycle = get_cycle_for_plottype(allattrs, P) add_cycle_attributes!(allattrs, P, cycle, la.cycler, la.palette)