Skip to content

Commit

Permalink
Fix DataInspector using invalid attribute strokewidth for plot type W…
Browse files Browse the repository at this point in the history
…ireframe (#3917)

* wireframe strokewidth should be linewidth

* Update CHANGELOG.md
  • Loading branch information
jaakkor2 authored Jul 2, 2024
1 parent 8ce89ac commit 36f4397
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
- Fix stack overflows when using `markerspace = :data` with `scatter` [#3960](https://github.com/MakieOrg/Makie.jl/issues/3960).
- CairoMakie: Fix broken SVGs when using non-interpolated image primitives, for example Colorbars, with recent Cairo versions [#3967](https://github.com/MakieOrg/Makie.jl/pull/3967).
- CairoMakie: Add argument `pdf_version` to restrict the PDF version when saving a figure as a PDF [#3845](https://github.com/MakieOrg/Makie.jl/pull/3845).
- Fix DataInspector using invalid attribute strokewidth for plot type Wireframe [#3917](https://github.com/MakieOrg/Makie.jl/pull/3917).
- CairoMakie: Fix incorrect scaling factor for SVGs with Cairo_jll 1.18 [#3964](https://github.com/MakieOrg/Makie.jl/pull/3964).
- Fixed use of Textbox from Bonito [#3924](https://github.com/MakieOrg/Makie.jl/pull/3924)

Expand Down
2 changes: 1 addition & 1 deletion src/interaction/inspector.jl
Original file line number Diff line number Diff line change
Expand Up @@ -827,7 +827,7 @@ function show_data(inspector::DataInspector, plot::BarPlot, idx)
clear_temporary_plots!(inspector, plot)
p = wireframe!(
scene, bbox, model = model, color = a.indicator_color,
strokewidth = a.indicator_linewidth, linestyle = a.indicator_linestyle,
linewidth = a.indicator_linewidth, linestyle = a.indicator_linestyle,
visible = a.indicator_visible, inspectable = false
)
translate!(p, Vec3f(0, 0, a.depth[]))
Expand Down

0 comments on commit 36f4397

Please sign in to comment.