From 6cfa9f71608ce4ae3c4236c83c61462de54662e9 Mon Sep 17 00:00:00 2001
From: ffreyer <frederic481994@hotmail.de>
Date: Fri, 26 Apr 2024 00:48:17 +0200
Subject: [PATCH] fix test?

---
 GLMakie/assets/shader/lines.geom | 7 +++++--
 WGLMakie/src/Lines.js            | 7 +++++--
 WGLMakie/src/wglmakie.bundled.js | 7 +++++--
 3 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/GLMakie/assets/shader/lines.geom b/GLMakie/assets/shader/lines.geom
index 500df08f7f7..f6c198f728d 100644
--- a/GLMakie/assets/shader/lines.geom
+++ b/GLMakie/assets/shader/lines.geom
@@ -84,6 +84,7 @@ void emit_vertex(LineVertex vertex) {
 
 vec2 normal_vector(in vec2 v) { return vec2(-v.y, v.x); }
 vec2 normal_vector(in vec3 v) { return vec2(-v.y, v.x); }
+float sign_no_zero(float value) { return value >= 0.0 ? 1.0 : -1.0; }
 
 
 ////////////////////////////////////////////////////////////////////////////////
@@ -292,8 +293,10 @@ void main(void)
     // Note: n0 + n1 = vec(0) for a 180° change in direction. +-(v0 - v1) is the
     //       same direction, but becomes vec(0) at 0°, so we can use it instead
     vec2 miter = vec2(dot(v0, v1.xy), dot(v1.xy, v2));
-    vec2 miter_n1 = miter.x < -0.0 ? sign(dot(v0.xy, n1)) * normalize(v0.xy - v1.xy) : normalize(n0 + n1);
-    vec2 miter_n2 = miter.y < -0.0 ? sign(dot(v1.xy, n2)) * normalize(v1.xy - v2.xy) : normalize(n1 + n2);
+    vec2 miter_n1 = miter.x < 0.0 ?
+        sign_no_zero(dot(v0.xy, n1)) * normalize(v0.xy - v1.xy) : normalize(n0 + n1);
+    vec2 miter_n2 = miter.y < 0.0 ?
+        sign_no_zero(dot(v1.xy, n2)) * normalize(v1.xy - v2.xy) : normalize(n1 + n2);
 
     // Are we truncating the joint based on miter limit or joinstyle?
     // bevel / always truncate doesn't work with v1 == v2 (v0) so we use allow
diff --git a/WGLMakie/src/Lines.js b/WGLMakie/src/Lines.js
index 39e9d5587d8..03850e5701a 100644
--- a/WGLMakie/src/Lines.js
+++ b/WGLMakie/src/Lines.js
@@ -333,6 +333,7 @@ function lines_vertex_shader(uniforms, attributes, is_linesegments) {
 
             vec2 normal_vector(in vec2 v) { return vec2(-v.y, v.x); }
             vec2 normal_vector(in vec3 v) { return vec2(-v.y, v.x); }
+            float sign_no_zero(float value) { return value >= 0.0 ? 1.0 : -1.0; }
 
 
             ////////////////////////////////////////////////////////////////////////
@@ -430,8 +431,10 @@ function lines_vertex_shader(uniforms, attributes, is_linesegments) {
                 // Note: n0 + n1 = vec(0) for a 180° change in direction. +-(v0 - v1) is the
                 //       same direction, but becomes vec(0) at 0°, so we can use it instead
                 vec2 miter = vec2(dot(v0, v1.xy), dot(v1.xy, v2));
-                vec2 miter_n1 = miter.x < -0.0 ? sign(dot(v0.xy, n1)) *normalize(v0.xy - v1.xy) : normalize(n0 + n1);
-                vec2 miter_n2 = miter.y < -0.0 ? sign(dot(v1.xy, n2)) *normalize(v1.xy - v2.xy) : normalize(n1 + n2);
+                vec2 miter_n1 = miter.x < -0.0 ?
+                    sign_no_zero(dot(v0.xy, n1)) * normalize(v0.xy - v1.xy) : normalize(n0 + n1);
+                vec2 miter_n2 = miter.y < -0.0 ?
+                    sign_no_zero(dot(v1.xy, n2)) * normalize(v1.xy - v2.xy) : normalize(n1 + n2);
 
                 // Are we truncating the joint based on miter limit or joinstyle?
                 // bevel / always truncate doesn't work with v1 == v2 (v0) so we use allow
diff --git a/WGLMakie/src/wglmakie.bundled.js b/WGLMakie/src/wglmakie.bundled.js
index 63357f21399..ae5a10200b0 100644
--- a/WGLMakie/src/wglmakie.bundled.js
+++ b/WGLMakie/src/wglmakie.bundled.js
@@ -21610,6 +21610,7 @@ function lines_vertex_shader(uniforms, attributes, is_linesegments) {
 
             vec2 normal_vector(in vec2 v) { return vec2(-v.y, v.x); }
             vec2 normal_vector(in vec3 v) { return vec2(-v.y, v.x); }
+            float sign_no_zero(float value) { return value >= 0.0 ? 1.0 : -1.0; }
 
 
             ////////////////////////////////////////////////////////////////////////
@@ -21707,8 +21708,10 @@ function lines_vertex_shader(uniforms, attributes, is_linesegments) {
                 // Note: n0 + n1 = vec(0) for a 180° change in direction. +-(v0 - v1) is the
                 //       same direction, but becomes vec(0) at 0°, so we can use it instead
                 vec2 miter = vec2(dot(v0, v1.xy), dot(v1.xy, v2));
-                vec2 miter_n1 = miter.x < -0.0 ? sign(dot(v0.xy, n1)) *normalize(v0.xy - v1.xy) : normalize(n0 + n1);
-                vec2 miter_n2 = miter.y < -0.0 ? sign(dot(v1.xy, n2)) *normalize(v1.xy - v2.xy) : normalize(n1 + n2);
+                vec2 miter_n1 = miter.x < -0.0 ?
+                    sign_no_zero(dot(v0.xy, n1)) * normalize(v0.xy - v1.xy) : normalize(n0 + n1);
+                vec2 miter_n2 = miter.y < -0.0 ?
+                    sign_no_zero(dot(v1.xy, n2)) * normalize(v1.xy - v2.xy) : normalize(n1 + n2);
 
                 // Are we truncating the joint based on miter limit or joinstyle?
                 // bevel / always truncate doesn't work with v1 == v2 (v0) so we use allow