Skip to content

Commit

Permalink
remove unused uniforms Dict
Browse files Browse the repository at this point in the history
  • Loading branch information
ffreyer committed Sep 18, 2023
1 parent a9126c9 commit 76a41a9
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions GLMakie/src/GLAbstraction/GLTypes.jl
Original file line number Diff line number Diff line change
Expand Up @@ -441,11 +441,10 @@ function RenderObject(
end
end
buffers = filter(((key, value),) -> isa(value, GLBuffer) || key === :indices, data)
uniforms = filter(((key, value),) -> !isa(value, GLBuffer) && key !== :indices, data)
merge!(data, passthrough) # in the end, we insert back the non opengl data, to keep things simple
program = gl_convert(to_value(program), data) # "compile" lazyshader
vertexarray = GLVertexArray(Dict(buffers), program)
visible = pop!(uniforms, :visible, Observable(true))
visible = pop!(data, :visible, Observable(true))
# remove all uniforms not occuring in shader
# ssao, instances transparency are special for rendering passes. TODO do this more cleanly
special = Set([:ssao, :transparency, :instances, :fxaa])
Expand Down

0 comments on commit 76a41a9

Please sign in to comment.