diff --git a/CHANGELOG.md b/CHANGELOG.md index a94bd133672..eb3b938e8f6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,7 @@ ## [Unreleased] +- Fixed support for GLFW 3.4 on OSX [#3999](https://github.com/MakieOrg/Makie.jl/issues/3999). - Changed camera variables to Float64 for increased accuracy [#3984](https://github.com/MakieOrg/Makie.jl/pull/3984) - Allow CairoMakie to render `poly` overloads that internally don't use two child plots [#3986](https://github.com/MakieOrg/Makie.jl/pull/3986). - Fixes for Menu and DataInspector [#3975](https://github.com/MakieOrg/Makie.jl/pull/3975). diff --git a/GLMakie/src/screen.jl b/GLMakie/src/screen.jl index 0bab3fd248e..01bc19ae54d 100644 --- a/GLMakie/src/screen.jl +++ b/GLMakie/src/screen.jl @@ -257,7 +257,10 @@ function empty_screen(debugging::Bool; reuse=true) rethrow(e) end - GLFW.SetWindowIcon(window, Makie.icon()) + # GLFW doesn't support setting the icon on OSX + if !Sys.isapple() + GLFW.SetWindowIcon(window, Makie.icon()) + end # tell GLAbstraction that we created a new context. # This is important for resource tracking, and only needed for the first context