Bump actions/upload-artifact from 3 to 4 (#3480)

* Bump actions/upload-artifact from 3 to 4

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* don't overwrite artifacts

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: SimonDanisch <sdanisch@protonmail.com>

.github/workflows/Docs.yml

@@ -45,7 +45,7 @@ jobs:
           DISPLAY=:0 xvfb-run -s '-screen 0 1024x768x24'
           julia --color=yes makedocs.jl
     - name: Upload site as artifact
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: Docs build
         path: ./docs/__site

.github/workflows/reference_tests.yml

@@ -6,7 +6,6 @@ on:
       - '*.md'
     branches:
       - master
-      - sd/beta-20
   push:
     tags:
       - '*'
@@ -52,7 +51,7 @@ jobs:
           && echo "TESTS_SUCCESSFUL=true" >> $GITHUB_ENV
       - name: Upload test Artifacts
         if: matrix.version == '1'
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: ReferenceImages_CairoMakie
           path: ./CairoMakie/test/recorded_reference_images/
@@ -102,12 +101,13 @@ jobs:
           && echo "TESTS_SUCCESSFUL=true" >> $GITHUB_ENV
       - name: Upload test Artifacts
         if: matrix.version == '1'
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: ReferenceImages_GLMakie
           path: |
             ./GLMakie/test/recorded_reference_images/
       - name: Save number of missing refimages to file
+        if: matrix.version == '1'
         env:
           N_MISSING: ${{ steps.referencetests.outputs.n_missing_refimages }}
           COMMIT_SHA: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
@@ -116,7 +116,8 @@ jobs:
           echo $N_MISSING > ./n_missing/n_missing_refimages
           echo $COMMIT_SHA >> ./n_missing/n_missing_refimages
       - name: Upload artifact with number of missing refimages
-        uses: actions/upload-artifact@v3
+        if: matrix.version == '1'
+        uses: actions/upload-artifact@v4
         with:
           name: n_missing_refimages
           path: n_missing/
@@ -163,7 +164,7 @@ jobs:
           && echo "TESTS_SUCCESSFUL=true" >> $GITHUB_ENV
       - name: Upload test Artifacts
         if: matrix.version == '1'
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: ReferenceImages_WGLMakie
           path: ./WGLMakie/test/recorded_reference_images/

.github/workflows/rprmakie.yaml

@@ -50,7 +50,7 @@ jobs:
           julia --color=yes --project=monorepo -e 'using Pkg; Pkg.test("RPRMakie", coverage=true)'
           && echo "TESTS_SUCCESSFUL=true" >> $GITHUB_ENV
       - name: Upload test Artifacts
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: ReferenceImages_${{ matrix.os }}_${{ matrix.arch }}_${{ matrix.version }}
           path: ./RPRMakie/test/recorded