add clip_planes attribute

MakieCore/src/basic_plots.jl

@@ -12,6 +12,7 @@ default_theme(scene) = generic_plot_attributes!(Attributes())
 - `depth_shift::Float32 = 0f0` adjusts the depth value of a plot after all other transformations, i.e. in clip space, where `0 <= depth <= 1`. This only applies to GLMakie and WGLMakie and can be used to adjust render order (like a tunable overdraw).
 - `model::Makie.Mat4f` sets a model matrix for the plot. This replaces adjustments made with `translate!`, `rotate!` and `scale!`.
 - `space::Symbol = :data` sets the transformation space for box encompassing the volume plot. See `Makie.spaces()` for possible inputs.
+- `clip_planes`: TODO: docs
 """
 function generic_plot_attributes!(attr)
     attr[:transformation] = automatic
@@ -26,6 +27,7 @@ function generic_plot_attributes!(attr)
     attr[:inspector_label] = automatic
     attr[:inspector_clear] = automatic
     attr[:inspector_hover] = automatic
+    attr[:clip_planes] = automatic
     return attr
 end
 
@@ -42,7 +44,9 @@ function generic_plot_attributes(attr)
         space = attr[:space],
         inspector_label = attr[:inspector_label],
         inspector_clear = attr[:inspector_clear],
-        inspector_hover = attr[:inspector_hover]
+        inspector_hover = attr[:inspector_hover],
+        clip_planes =  attr[:clip_planes]
+
     )
 end
 
@@ -73,6 +77,8 @@ function mixin_generic_plot_attributes()
         inspector_clear = automatic
         "Sets a callback function `(inspector, plot, index) -> ...` which replaces the default `show_data` methods."
         inspector_hover = automatic
+        "TODO: docs"
+        clip_planes = automatic
     end
 end
 

src/interfaces.jl

@@ -377,7 +377,12 @@ function connect_plot!(parent::SceneLike, plot::Plot{F}) where {F}
     plot.model = transformationmatrix(plot)
     calculated_attributes!(Plot{F}, plot)
     default_shading!(plot, parent_scene(parent))
+    if to_value(get(attributes(plot), :clip_planes, automatic)) === automatic
+        attributes(plot)[:clip_planes] = map(identity, plot, scene.theme[:clip_planes])
+    end
+
     plot!(plot)
+
     conversions = get_conversions(plot)
     if !isnothing(conversions)
         connect_conversions!(scene.conversions, conversions)

src/theming.jl

@@ -70,6 +70,7 @@ const MAKIE_DEFAULT_THEME = Attributes(
         # N_samples = 64,       # number of samples (requires shader reload)
     ),
     inspectable = true,
+    clip_planes = Vector{Plane3f}(),
 
     # Vec is equvalent to 36° right/east, 39° up/north from camera position
     # The order here is Vec3f(right of, up from, towards) viewer/camera