Merge branch 'master' into cscale-overlap

MakieOrg · Aug 31, 2023 · ae544e2 · ae544e2
2 parents ae99f7e + ce20845
commit ae544e2
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/.github/workflows/glmakie.yaml b/.github/workflows/glmakie.yaml
@@ -66,9 +66,11 @@ jobs:
       - name: Save number of missing refimages to file
         env:
           N_MISSING: ${{ steps.referencetests.outputs.n_missing_refimages }}
+          COMMIT_SHA: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
         run: |
           mkdir -p ./n_missing
           echo $N_MISSING > ./n_missing/n_missing_refimages
+          echo $COMMIT_SHA >> ./n_missing/n_missing_refimages
       - name: Upload artifact with number of missing refimages
         uses: actions/upload-artifact@v3
         with:

diff --git a/.github/workflows/refimages_status.yaml b/.github/workflows/refimages_status.yaml
@@ -45,20 +45,21 @@ jobs:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           script: |
             let fs = require('fs');
-            let n_missing = Number(fs.readFileSync('./n_missing_refimages'));
+            let content = fs.readFileSync('./n_missing_refimages', { encoding: 'utf8' });
+            let lines = content.split('\n');
+            let n_missing = Number(lines[0]);
+            let commit_sha = lines[1];
 
             await github.request('POST /repos/{owner}/{repo}/statuses/{sha}', {
               owner: context.repo.owner,
               repo: context.repo.repo,
-              sha: "${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}",
+              sha: commit_sha,
               state: n_missing === 0 ? 'success' : 'failure',
               target_url: null,
               description: n_missing + " missing refimages must be uploaded",
               context: 'Reference Tests',
               headers: {
                 'X-GitHub-Api-Version': '2022-11-28'
               }
-            })
-
-            
+            })            
       
diff --git a/docs/_css/makie.css b/docs/_css/makie.css
@@ -778,6 +778,10 @@ button.copy-code {
     align-items: center;
 }
 
+button.copy-code .far {
+    font-family: "Font Awesome 5 Free";
+}
+
 .copied-text {
     font-size: 0.6em;
     margin-right: 0.2em;