From b9f25b912f3a03dd63dc8074236f12e34e86466b Mon Sep 17 00:00:00 2001
From: Phillip Alday <palday@users.noreply.github.com>
Date: Fri, 25 Aug 2023 10:07:52 +0000
Subject: [PATCH] fix error bar range in recipes (#3179)

* fix error bar range in recipes

* point_iterator instead of data_limits

* NEWS

* hexbin point iterator

* bracket
---
 NEWS.md                                  | 2 ++
 src/basic_recipes/bracket.jl             | 8 ++++----
 src/basic_recipes/error_and_rangebars.jl | 4 ++--
 src/stats/hexbin.jl                      | 4 ++--
 4 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/NEWS.md b/NEWS.md
index 1293e36a138..7483aea078e 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -2,6 +2,8 @@
 
 ## master
 
+- Fixed regression in determining axis limits [#3179](https://github.com/MakieOrg/Makie.jl/pull/3179)
+
 ## v0.19.8
 
 - Improved CairoMakie rendering of `lines` with repeating colors in an array [#3141](https://github.com/MakieOrg/Makie.jl/pull/3141).
diff --git a/src/basic_recipes/bracket.jl b/src/basic_recipes/bracket.jl
index 140e20a0395..bb2426f7c77 100644
--- a/src/basic_recipes/bracket.jl
+++ b/src/basic_recipes/bracket.jl
@@ -54,7 +54,7 @@ function Makie.plot!(pl::Bracket)
         return to === automatic ? Float32.(0.75 .* fs) : Float32.(to)
     end
 
-    onany(pl, points, scene.camera.projectionview, pl.model, transform_func(pl), 
+    onany(pl, points, scene.camera.projectionview, pl.model, transform_func(pl),
           scene.px_area, pl.offset, pl.width, pl.orientation, realtextoffset,
           pl.style) do points, _, _, _, _, offset, width, orientation, textoff, style
 
@@ -108,7 +108,7 @@ function Makie.plot!(pl::Bracket)
     end
 
     # Avoid scale!() / translate!() / rotate!() to affect these
-    series!(pl, bp; space = :pixel, solid_color = pl.color, linewidth = pl.linewidth, 
+    series!(pl, bp; space = :pixel, solid_color = pl.color, linewidth = pl.linewidth,
         linestyle = pl.linestyle, transformation = Transformation())
     text!(pl, textpoints, text = texts, space = :pixel, align = pl.align, offset = textoffset_vec,
         fontsize = pl.fontsize, font = pl.font, rotation = autorotations, color = pl.textcolor,
@@ -116,8 +116,8 @@ function Makie.plot!(pl::Bracket)
     pl
 end
 
-data_limits(pl::Bracket) = mapreduce(union, pl[1][]) do points
-    Rect3f([points...])
+function point_iterator(pl::Bracket)
+    point_iterator(pl.plots[1])
 end
 
 bracket_bezierpath(style::Symbol, args...) = bracket_bezierpath(Val(style), args...)
diff --git a/src/basic_recipes/error_and_rangebars.jl b/src/basic_recipes/error_and_rangebars.jl
index 4afdef6b749..fd8e07664e8 100644
--- a/src/basic_recipes/error_and_rangebars.jl
+++ b/src/basic_recipes/error_and_rangebars.jl
@@ -280,6 +280,6 @@ function screen_to_plot(plot, p::VecTypes)
 end
 
 # ignore whiskers when determining data limits
-function data_limits(bars::Union{Errorbars, Rangebars})
-    data_limits(bars.plots[1])
+function point_iterator(bars::Union{Errorbars, Rangebars})
+    point_iterator(bars.plots[1])
 end
diff --git a/src/stats/hexbin.jl b/src/stats/hexbin.jl
index 17501642235..0f50e745ec8 100644
--- a/src/stats/hexbin.jl
+++ b/src/stats/hexbin.jl
@@ -62,7 +62,7 @@ end
 
 Makie.conversion_trait(::Type{<:Hexbin}) = PointBased()
 
-function data_limits(hb::Hexbin)
+function point_iterator(hb::Hexbin)
     bb = Rect3f(hb.plots[1][1][])
     fn(num::Real) = Float32(num)
     fn(tup::Union{Tuple,Vec2}) = Vec2f(tup...)
@@ -71,7 +71,7 @@ function data_limits(hb::Hexbin)
     nw = widths(bb) .+ (ms..., 0.0f0)
     no = bb.origin .- ((ms ./ 2.0f0)..., 0.0f0)
 
-    return Rect3f(no, nw)
+    return decompose(Point2f, Rect3f(no, nw))
 end
 
 get_weight(weights, i) = Float64(weights[i])