Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data_limits should respect the plot's transformation #2800

Closed
asinghvi17 opened this issue Mar 22, 2023 · 2 comments
Closed

data_limits should respect the plot's transformation #2800

asinghvi17 opened this issue Mar 22, 2023 · 2 comments

Comments

@asinghvi17
Copy link
Member

Right now, if I translate a plot, that doesn't reflect in data_limits.

Ideally, my sense is that it would reflect there.

@ffreyer
Copy link
Collaborator

ffreyer commented Mar 22, 2023

I think data_limits and boundingbox also need to be defined more clearly.

I'd say data_limits should probably just look at plot.converted and ignore the extent or markers, scattered meshes, heatmaps, etc. boundingbox should include that stuff. It would probably also be useful to have boundingboxes that returns a boundingbox per element. (Or a boundingbox(plot, index)?)

When it comes to applying transformation I think the untouched version should probably just look at the raw data. I.e. the bounding box/limits should match up if you apply all the same transformations. Though for usability I think we should just have target_space as an argument in these functions.

@SimonDanisch
Copy link
Member

Closed in favor of #2881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants