Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataInspector fixes #3454

Merged
merged 8 commits into from
Dec 18, 2023
Merged

DataInspector fixes #3454

merged 8 commits into from
Dec 18, 2023

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Dec 7, 2023

Description

Fixes #3450. This came from position_on_plot applying transformations to the position that is later displayed.

Fixes #3436. This was a result of transformations no longer connecting when the spaces differ. I adjusted tooltip to handle it internally, since it already did an (incomplete) transformation to pixel space before.

Fixes #3353.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@MakieBot
Copy link
Collaborator

MakieBot commented Dec 7, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 3.55s (3.49, 3.61) 0.04+- 375.70ms (314.51, 390.71) 27.18+- 467.62ms (464.66, 470.27) 2.24+- 7.23ms (6.88, 7.41) 0.18+- 25.57ms (25.20, 26.19) 0.32+-
master 3.57s (3.45, 3.70) 0.10+- 408.25ms (394.31, 431.96) 14.00+- 481.62ms (465.78, 513.30) 15.11+- 7.30ms (7.18, 7.41) 0.09+- 25.56ms (25.19, 25.93) 0.25+-
evaluation 1.00x invariant, -0.02s (-0.20d, 0.71p, 0.07std) 1.09x faster✅, -32.55ms (-1.51d, 0.02p, 20.59std) 1.03x faster ✓, -14.0ms (-1.30d, 0.05p, 8.68std) 1.01x invariant, -0.07ms (-0.48d, 0.39p, 0.14std) 1.00x invariant, 0.02ms (0.06d, 0.92p, 0.29std)
CairoMakie 3.06s (3.00, 3.13) 0.05+- 323.92ms (320.30, 328.89) 3.53+- 144.12ms (142.52, 146.36) 1.36+- 7.53ms (7.43, 7.69) 0.10+- 611.34μs (604.99, 617.85) 4.50+-
master 3.04s (3.00, 3.12) 0.04+- 321.46ms (318.21, 328.58) 3.74+- 142.22ms (140.85, 143.89) 1.01+- 7.19ms (7.10, 7.43) 0.12+- 599.24μs (594.75, 606.22) 3.84+-
evaluation 1.00x invariant, 0.01s (0.24d, 0.67p, 0.05std) 0.99x invariant, 2.46ms (0.68d, 0.23p, 3.63std) 0.99x slower X, 1.9ms (1.59d, 0.01p, 1.19std) 0.95x slower X, 0.34ms (3.15d, 0.00p, 0.11std) 0.98x slower X, 12.1μs (2.89d, 0.00p, 4.17std)
WGLMakie 3.93s (3.85, 3.99) 0.05+- 348.06ms (330.78, 364.66) 11.63+- 9.21s (9.10, 9.37) 0.09+- 9.76ms (9.35, 10.52) 0.43+- 71.29ms (67.35, 78.12) 3.64+-
master 3.90s (3.75, 3.97) 0.08+- 337.74ms (318.06, 350.68) 10.57+- 9.03s (8.54, 9.22) 0.24+- 9.80ms (9.58, 9.91) 0.13+- 73.27ms (69.03, 81.04) 5.28+-
evaluation 0.99x invariant, 0.03s (0.47d, 0.40p, 0.06std) 0.97x invariant, 10.33ms (0.93d, 0.11p, 11.10std) 0.98x invariant, 0.18s (1.00d, 0.10p, 0.17std) 1.00x invariant, -0.04ms (-0.12d, 0.83p, 0.28std) 1.03x invariant, -1.98ms (-0.44d, 0.43p, 4.46std)

@ffreyer ffreyer marked this pull request as ready for review December 7, 2023 14:56
@SimonDanisch SimonDanisch merged commit d11b786 into master Dec 18, 2023
15 checks passed
@SimonDanisch SimonDanisch deleted the ff/DataInspector branch December 18, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants