Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scatterlines! color does not cycle if different number of data points #3629

Closed
3 tasks done
nathanrboyer opened this issue Feb 13, 2024 · 2 comments
Closed
3 tasks done
Labels
bug Makie Backend independent issues (Makie core)

Comments

@nathanrboyer
Copy link

  • are you running newest version (version from docs) ? GLMakie v0.9.8
  • can you reproduce the bug with a fresh environment ? (]activate --temp; add Makie) Same behavior
  • What platform + GPU are you on? Windows 11 with Nvidia GeForce RTX 2060

I would expect each of these lines to have a different color. It used to work that way, and lines! does work that way.

using GLMakie
fig = Figure()
axis = Axis(fig[1,1])
scatterlines!(axis, 0:1, 1:2, label="A")
scatterlines!(axis, 0:0.1:1, 2:0.1:3, label="B")
scatterlines!(axis, 0:1, 3:4, label="C")
Legend(fig[1,2], axis, "Label")
display(fig)

labelerror

using GLMakie
fig = Figure()
axis = Axis(fig[1,1])
lines!(axis, 0:1, 1:2, label="A")
lines!(axis, 0:0.1:1, 2:0.1:3, label="B")
lines!(axis, 0:1, 3:4, label="C")
Legend(fig[1,2], axis, "Label")
display(fig)

labelerror

@asinghvi17
Copy link
Member

asinghvi17 commented Feb 13, 2024

I can't replicate this on master (i.e., it works as expected) but I can on the latest version as you said @nathanrboyer.

The only thing which touched scatterlines since the last release was #3603, and running that code does indeed solve the issue:

iTerm2 9qEIOV

You need to run

Makie.conversion_trait(::Type{<: ScatterLines}) = PointBased()

although I am not entirely sure why this would fix a theming issue. Maybe because cycling was only enabled for point-based plots?

@asinghvi17 asinghvi17 added the Makie Backend independent issues (Makie core) label Feb 13, 2024
@ffreyer
Copy link
Collaborator

ffreyer commented Aug 27, 2024

Closing as fixed/not reproducible

@ffreyer ffreyer closed this as completed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Makie Backend independent issues (Makie core)
Projects
None yet
Development

No branches or pull requests

3 participants