Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix keyboard entry for WGLMakie Textbox #3924

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

bjarthur
Copy link
Contributor

@bjarthur bjarthur commented Jun 3, 2024

Description

fixes SimonDanisch/Bonito.jl#154

users can now enter text into a Makie.Textbox from a web app created with Bonito.jl

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)

@bjarthur
Copy link
Contributor Author

bjarthur commented Jun 3, 2024

@EdsterG

@bjarthur
Copy link
Contributor Author

tests pass. ready for review.

@EdsterG have you had a chance to try this branch? it resolves your issue.

@SimonDanisch
Copy link
Member

Thank you!

@SimonDanisch SimonDanisch merged commit 5f70c5b into MakieOrg:master Jun 19, 2024
18 checks passed
@bjarthur bjarthur deleted the bja/textbox branch June 20, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard input doesn't work
2 participants