Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fontsize does not propagate into PolarAxis #3928

Closed
pzabka opened this issue Jun 4, 2024 · 2 comments
Closed

fontsize does not propagate into PolarAxis #3928

pzabka opened this issue Jun 4, 2024 · 2 comments
Labels
Attributes Plot, Block and Scene Attributes bug good first issue This should come with some instructions! PolarAxis

Comments

@pzabka
Copy link

pzabka commented Jun 4, 2024

The parameter fontsize does not propagate into PolarAxis

This works:

fig = Figure()
ax = PolarAxis(fig[1, 1]; rticklabelsize = 50, thetaticklabelsize = 50)
fig

This doesn't:

fig = Figure(fontsize = 50)
ax = PolarAxis(fig[1, 1])
fig

Tested with:
GLMakie v0.10.2
CairoMakie v0.12.2
@pzabka pzabka added the bug label Jun 4, 2024
@ffreyer
Copy link
Collaborator

ffreyer commented Jun 4, 2024 •
edited
Loading

Should be easy to fix by changing the relevant attributes to inherit from fontsize like Axis. See https://github.com/MakieOrg/Makie.jl/blob/master/src/makielayout/types.jl

@ffreyer ffreyer added the good first issue This should come with some instructions! label Jun 4, 2024
@ffreyer ffreyer added Attributes Plot, Block and Scene Attributes PolarAxis labels Aug 28, 2024
NeunMonde added a commit to NeunMonde/Makie.jl that referenced this issue Sep 4, 2024
@NeunMonde
Added way for PolarAxis to pull fontsize attribute from Figure
62596f0 
Adjusted the "rticklabelsize" and "thetaticklabelsize" properties in the "types.jl" file to fall back to inheriting the fontsize from the Figure, if the ticklabelsize is not defined. This fixes issue MakieOrg#3928 (MakieOrg#3928).
@NeunMonde NeunMonde mentioned this issue Sep 4, 2024
Merged
7 tasks
ffreyer added a commit that referenced this issue Sep 30, 2024
@NeunMonde @SimonDanisch @ffreyer
Added way for PolarAxis to pull fontsize attribute from Figure (#4314)
4f2971d 
* Added way for PolarAxis to pull fontsize attribute from Figure

Adjusted the "rticklabelsize" and "thetaticklabelsize" properties in the "types.jl" file to fall back to inheriting the fontsize from the Figure, if the ticklabelsize is not defined. This fixes issue #3928 (#3928).

* Added reference tests and changes to CHANGELOG.md for PR #4314

* Corrected and moved reference tests

* Removed trailing whitespace

* Changed frontsize inheritance according to discussion in PR #4314

yticklabelsize now propagates into rticklabelsize instead of thetaticklabelsize and xticklabelsize now propagates into thetaticklabelsize

* Added unit tests similar to image reference tests for PolarAxis fontsize

* Removed reference image tests

> Actually I think this would be better as unit tests. There is already a refimg test for decorations that should confirm that changing r-/thetaticklabelsize has the desired effect. So here you just need to confirm that the PolarAxis is correctly inheriting values.

* Made changelog entry message clearer to understand

* Update testset (PolarAxis from Theme) to use correct code for theming

* Fixed indentation issues

* Update CHANGELOG.md

---------

Co-authored-by: Simon <sdanisch@protonmail.com>
Co-authored-by: Frederic Freyer <frederic481994@hotmail.de>
@ffreyer
Copy link
Collaborator

ffreyer commented Oct 10, 2024

Fixed by #4314

@ffreyer ffreyer closed this as completed Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Attributes Plot, Block and Scene Attributes bug good first issue This should come with some instructions! PolarAxis
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ffreyer @pzabka