-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow width
to be set per box in boxplot
#4447
Conversation
This PR is good to go on my end. Would like to add a test but it overlaps with #4433. How would you like to coordinate it @ffreyer? Can ether wait for #4433 to get merged, OR if this PR is merged before, #4433 can easily be updated to test width, e.g. |
# Conflicts: # CHANGELOG.md
I'll try to get my test related prs merged in the next couple days. If you want you can copy the test from #4433 and add a modified version here, but I think it's easy enough to modify and recognize errors that I can do it later myself. |
Why do the tests fail on scatter? I thought that was fixed and RNG stabilized? |
The PlotUtils fix changed the RNG to StableRNG so the test was expected to fail. I uploaded a new refimg for #4464 now so new test rus should pass. |
Nice, thanks for fixing these test issues and for adding all of the new tests. |
@ffreyer I've updated the ref image tests to include variable width per category, just needs an update to the ref images. If I understood correctly, only maintainers can update the ref images? |
Thanks for updating. I uploaded the new refimages and the remaining failure is unrelated to this pr so I'm merging this. |
Description
Allows width to be set per box. Not sure if this is a bug fix or new feature, classified it as a bug fix since colors can be set per box.
This also fixes
boxplot
whenrange
is zero. Before this PR nothing would get plotted (because the color vector was empty), after this PR the plot works correctly with zero range.Type of change
Checklist