-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Make array handling in converts as generic as possible #2756
base: master
Are you sure you want to change the base?
Conversation
Compile Times benchmarkNote, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running: using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
|
I think we can merge this, but should add a test first! |
Ok, added some tests and cleaned it up... But I think we need to make this a breaking change. |
Missing reference imagesFound 1 new images without existing references. |
This is still unmerged AFAIK. Should we target |
Description
Fixes #2753
Allows OffsetArrays, and generally any array which overloads
Base.axes
, to be plotted with the correct indices by anySurfaceLike
orVolumeLike
plot. Changes here might conflict with #2573 so we could merge after or into that PR.Type of change
Delete options that do not apply:
Checklist