-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datashader #2883
Datashader #2883
Conversation
Compile Times benchmarkNote, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running: using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
|
It would be interesting to have a "datashader axis", which has the capability to datashade any plot plotted into it. It could theoretically do this by just consuming the atomic plot elements (lines + linesegments + scatter) and rasterizing them. Surfacelikes could potentially be disallowed/ignored. This might be useful to visualize densely connected graph clusters and similar strategies. We could then also |
…into jk/datashader
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is huge, should be mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(and you can also embed videos such that they auto-play and auto-loop)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
src/basic_recipes/datashader.jl
Outdated
colormap = theme(scene, :colormap), | ||
colorrange = automatic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO the colorrange calculation should be slightly changed here, so that we don't have to fiddle with colormaps. Let the colorrange be (1, max) instead of (0, max), then set lowclip = :transparent
, or :black
, or what have you. This should also make the colormap a lot more exact!
Missing reference imagesFound 1 new images without existing references. |
Missing reference imagesFound 1 new images without existing references. |
Missing reference imagesFound 1 new images without existing references. |
@jkrumbiegel I'm going to merge this when this goes green... It's still not perfect, but I cant invest much more time into this. |
Yeah I'm ok with that. Not much more movement on it, maybe once people can actually use it. |
Should this work together with the new CategoricalColormap? |
What's the legend element with the gradient? Did you add a new legend element kind? |
It's a poly marker with per vertex color ;) |
While it's kind of cool, I think I'd still change those to normal solid colors. It's the color that tells you the category, not the alpha. |
Copied the prototype from https://github.com/cjdoris/ShadeYourData.jl over and modified it into a normal recipe. It's pretty slow when trackpad zooming (too many updates at once), but ok with the rectangle zoom.