-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare 0.19.7 release #3079
prepare 0.19.7 release #3079
Conversation
SimonDanisch
commented
Jul 20, 2023
•
edited
Loading
edited
- update project tomls
- update NEWS.md
- merge some more PRs!?
Damn, didn't realize that we now have something of a circular dependency via DelaunayTriangulation depending on MakieCore and Makie depending on DelaunayTriangulation, making it hard to release a breaking MakieCore version.... |
Compile Times benchmarkNote, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running: using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
|
@SimonDanisch: Is this a significant issue? Currently, MakieCore is a package extension inside DelaunayTriangulation, though that doesn't do anything <1.9. Is there a way I can change some of the code up inside DelaunayTriangulation to help you out here? |
I think now that makie depends on delaunaytriangulation, we could just move the extension code to Makie? |
That would be a good idea. Once I have some spare time, I will look into doing that. |