Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow arrows to take a Function to produce the vector #3080

Merged
merged 14 commits into from
Jul 22, 2023
Merged

Conversation

SimonDanisch
Copy link
Member

continuation of #2597

@MakieBot
Copy link
Collaborator

MakieBot commented Jul 21, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 16.57s (16.12, 17.14) 0.38+- 1.63s (1.58, 1.70) 0.04+- 1.06s (0.99, 1.11) 0.04+- 17.54ms (16.94, 18.27) 0.50+- 201.96ms (197.98, 206.03) 3.63+-
master 16.73s (16.37, 17.21) 0.30+- 1.59s (1.52, 1.67) 0.05+- 1.04s (1.00, 1.10) 0.03+- 17.34ms (17.01, 17.75) 0.28+- 200.91ms (199.02, 205.12) 2.34+-
evaluation -0.97%, -0.16s invariant (-0.47d, 0.39p, 0.34std) +2.92%, 0.05s invariant (0.96d, 0.10p, 0.05std) +1.13%, 0.01s invariant (0.31d, 0.58p, 0.04std) +1.18%, 0.21ms invariant (0.51d, 0.36p, 0.39std) +0.52%, 1.04ms invariant (0.34d, 0.54p, 2.98std)
CairoMakie 9.60s (9.54, 9.68) 0.05+- 1.05s (1.04, 1.07) 0.01+- 235.47ms (229.17, 243.77) 5.92+- 9.47ms (9.38, 9.65) 0.09+- 5.74ms (5.66, 5.86) 0.06+-
master 9.63s (9.60, 9.67) 0.03+- 1.05s (1.02, 1.08) 0.02+- 233.33ms (228.95, 238.68) 3.13+- 9.48ms (9.40, 9.61) 0.09+- 5.66ms (5.58, 5.75) 0.06+-
evaluation -0.33%, -0.03s invariant (-0.72d, 0.21p, 0.04std) +0.43%, 0.0s invariant (0.30d, 0.58p, 0.01std) +0.91%, 2.14ms invariant (0.45d, 0.42p, 4.52std) -0.01%, -0.0ms invariant (-0.01d, 0.99p, 0.09std) +1.51%, 0.09ms slower X (1.42d, 0.02p, 0.06std)
WGLMakie 12.18s (12.08, 12.29) 0.09+- 1.21s (1.15, 1.24) 0.03+- 11.87s (11.78, 12.03) 0.09+- 13.49ms (12.97, 14.16) 0.50+- 1.15s (1.12, 1.20) 0.03+-
master 12.20s (12.02, 12.41) 0.13+- 1.19s (1.13, 1.24) 0.05+- 11.87s (11.79, 11.94) 0.05+- 13.19ms (12.62, 13.96) 0.49+- 1.12s (1.06, 1.16) 0.04+-
evaluation -0.15%, -0.02s invariant (-0.16d, 0.78p, 0.11std) +1.61%, 0.02s invariant (0.49d, 0.38p, 0.04std) +0.05%, 0.01s invariant (0.08d, 0.89p, 0.07std) +2.27%, 0.31ms invariant (0.62d, 0.27p, 0.50std) +2.62%, 0.03s invariant (0.85d, 0.14p, 0.04std)

@SimonDanisch SimonDanisch merged commit 1734cf8 into master Jul 22, 2023
13 checks passed
@SimonDanisch SimonDanisch deleted the patch-4 branch July 22, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants