Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize screens as well when resizing scene #3093

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Conversation

SimonDanisch
Copy link
Member

We've been having resize!(scene/fig, w, h) for a long time, but they never actually resized the Screen.
With this PR, resize!(fig, w, h) works finally as expected.

@MakieBot
Copy link
Collaborator

MakieBot commented Jul 25, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 10.63s (10.55, 10.73) 0.05+- 1.04s (1.03, 1.06) 0.01+- 708.64ms (693.47, 765.59) 25.27+- 9.54ms (9.46, 9.61) 0.06+- 136.82ms (135.61, 137.88) 0.88+-
master 10.62s (10.59, 10.64) 0.02+- 1.05s (1.04, 1.06) 0.01+- 698.85ms (693.96, 707.25) 4.42+- 9.54ms (9.46, 9.66) 0.07+- 135.69ms (133.99, 136.63) 0.88+-
evaluation +0.17%, 0.02s invariant (0.46d, 0.42p, 0.04std) -0.99%, -0.01s invariant (-1.06d, 0.07p, 0.01std) +1.38%, 9.79ms invariant (0.54d, 0.35p, 14.85std) +0.03%, 0.0ms invariant (0.05d, 0.93p, 0.06std) +0.83%, 1.13ms slower X (1.29d, 0.03p, 0.88std)
CairoMakie 9.56s (9.43, 9.74) 0.11+- 1.05s (1.04, 1.06) 0.01+- 229.17ms (227.74, 231.08) 1.29+- 9.45ms (9.38, 9.56) 0.06+- 5.57ms (5.50, 5.62) 0.04+-
master 9.48s (9.38, 9.57) 0.07+- 1.04s (1.02, 1.09) 0.02+- 229.83ms (227.09, 234.52) 2.48+- 9.50ms (9.39, 9.87) 0.17+- 5.67ms (5.53, 6.02) 0.17+-
evaluation +0.88%, 0.08s invariant (0.93d, 0.11p, 0.09std) +0.44%, 0.0s invariant (0.26d, 0.64p, 0.02std) -0.29%, -0.66ms invariant (-0.33d, 0.55p, 1.89std) -0.54%, -0.05ms invariant (-0.40d, 0.48p, 0.12std) -1.76%, -0.1ms invariant (-0.79d, 0.18p, 0.11std)
WGLMakie 15.73s (15.48, 15.97) 0.20+- 1.53s (1.51, 1.58) 0.03+- 15.17s (14.82, 15.35) 0.19+- 19.97ms (19.51, 20.36) 0.29+- 1.37s (1.33, 1.42) 0.03+-
master 15.69s (15.48, 16.01) 0.20+- 1.53s (1.48, 1.61) 0.04+- 15.08s (14.83, 15.53) 0.26+- 20.52ms (19.18, 21.51) 0.88+- 1.40s (1.34, 1.45) 0.04+-
evaluation +0.22%, 0.04s invariant (0.18d, 0.75p, 0.20std) +0.13%, 0.0s invariant (0.06d, 0.91p, 0.03std) +0.57%, 0.09s invariant (0.37d, 0.50p, 0.23std) -2.75%, -0.55ms invariant (-0.84d, 0.16p, 0.58std) -2.40%, -0.03s invariant (-0.94d, 0.10p, 0.03std)

@SimonDanisch SimonDanisch merged commit d85ca14 into master Jul 25, 2023
13 checks passed
@SimonDanisch SimonDanisch deleted the sd/resize-screen branch July 25, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants