merge CURRENT_DEFAULT_THEME to scene.theme after empty! #3100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, good catch! I dont remember anymore, but looks like an accident to me! |
|
We should add a test for this, that's how it degraded to begin with... |
|
I just detected another regression regarding empty!(::Figure), that is not fixed by this PR. After I called empty! on a figure, the figure doesn't adjust anymore to window size changes. |
|
Hm, that one is harder to fix -.- |
SimonDanisch
added a commit
that referenced
this pull request
Jul 28, 2023
SimonDanisch
added a commit
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2817
But i do not know what was the intention to remove the merge! line in the commit 1fcfa68
Type of change
Delete options that do not apply: