Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PolarAxis tick align #3151

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Fix PolarAxis tick align #3151

merged 2 commits into from
Aug 14, 2023

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Aug 14, 2023

Description

Fixes #3150

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@MakieBot
Copy link
Collaborator

MakieBot commented Aug 14, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 13.75s (13.32, 14.15) 0.31+- 1.38s (1.29, 1.47) 0.06+- 894.45ms (831.83, 944.04) 37.71+- 16.20ms (15.85, 16.80) 0.35+- 192.73ms (190.65, 194.75) 1.83+-
master 14.45s (13.77, 15.11) 0.54+- 1.39s (1.32, 1.45) 0.05+- 895.31ms (867.36, 933.40) 26.29+- 16.16ms (15.55, 16.85) 0.39+- 189.75ms (186.63, 192.89) 2.31+-
evaluation -5.05%, -0.69s faster✅ (-1.57d, 0.02p, 0.43std) -0.88%, -0.01s invariant (-0.23d, 0.68p, 0.05std) -0.10%, -0.86ms invariant (-0.03d, 0.96p, 32.00std) +0.22%, 0.04ms invariant (0.10d, 0.86p, 0.37std) +1.55%, 2.98ms slower X (1.43d, 0.02p, 2.07std)
CairoMakie 11.53s (11.39, 11.63) 0.11+- 1.20s (1.18, 1.23) 0.02+- 247.44ms (241.53, 251.86) 4.21+- 11.74ms (11.62, 11.99) 0.13+- 6.91ms (6.81, 7.02) 0.08+-
master 11.52s (11.40, 11.63) 0.09+- 1.19s (1.15, 1.22) 0.02+- 242.57ms (233.86, 249.23) 5.29+- 11.69ms (11.45, 11.90) 0.14+- 6.97ms (6.86, 7.09) 0.08+-
evaluation +0.12%, 0.01s invariant (0.13d, 0.81p, 0.10std) +0.57%, 0.01s invariant (0.34d, 0.54p, 0.02std) +1.97%, 4.88ms invariant (1.02d, 0.08p, 4.75std) +0.46%, 0.05ms invariant (0.40d, 0.47p, 0.14std) -0.87%, -0.06ms invariant (-0.76d, 0.18p, 0.08std)
WGLMakie 15.57s (15.26, 15.82) 0.20+- 1.51s (1.44, 1.71) 0.09+- 14.50s (14.24, 14.77) 0.19+- 18.16ms (16.48, 21.51) 1.78+- 1.44s (1.37, 1.52) 0.05+-
master 15.64s (15.41, 15.89) 0.18+- 1.52s (1.48, 1.57) 0.03+- 14.44s (14.26, 14.58) 0.13+- 17.80ms (16.62, 18.27) 0.61+- 1.44s (1.41, 1.47) 0.03+-
evaluation -0.40%, -0.06s invariant (-0.33d, 0.55p, 0.19std) -0.10%, -0.0s invariant (-0.02d, 0.97p, 0.06std) +0.43%, 0.06s invariant (0.39d, 0.49p, 0.16std) +1.95%, 0.35ms invariant (0.27d, 0.63p, 1.19std) -0.35%, -0.01s invariant (-0.12d, 0.83p, 0.04std)

@SimonDanisch SimonDanisch merged commit d551d3c into master Aug 14, 2023
13 checks passed
@SimonDanisch SimonDanisch deleted the ff/polar-axis-fixes branch August 14, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theta ticks misaligned vertically with PolarAxis when direction=-1
3 participants