Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooling to bump versions #3155

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Add tooling to bump versions #3155

merged 1 commit into from
Aug 21, 2023

Conversation

jkrumbiegel
Copy link
Member

You should be on current master and then do include("tooling/bump_versions.jl") from the REPL. This tries to be a little bit smart in that it checks which src directories have changes, and it includes the dependencies to Makie.jl and MakieCore.jl.

@SimonDanisch try it out and let me know what you think

@MakieBot
Copy link
Collaborator

MakieBot commented Aug 15, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 13.57s (12.96, 16.01) 1.09+- 1.31s (1.24, 1.60) 0.13+- 866.84ms (821.16, 973.38) 56.52+- 16.17ms (15.54, 18.75) 1.15+- 186.14ms (185.13, 186.83) 0.63+-
master 13.31s (13.14, 13.60) 0.16+- 1.30s (1.27, 1.32) 0.02+- 854.62ms (820.68, 896.12) 22.74+- 15.71ms (15.48, 16.03) 0.23+- 190.08ms (183.29, 221.38) 13.85+-
evaluation +1.91%, 0.26s invariant (0.33d, 0.55p, 0.62std) +0.95%, 0.01s invariant (0.14d, 0.81p, 0.07std) +1.41%, 12.22ms invariant (0.28d, 0.61p, 39.63std) +2.88%, 0.47ms invariant (0.56d, 0.33p, 0.69std) -2.12%, -3.95ms invariant (-0.40d, 0.48p, 7.24std)
CairoMakie 10.65s (10.54, 10.82) 0.12+- 1.11s (1.07, 1.15) 0.03+- 234.00ms (224.35, 241.26) 6.76+- 10.99ms (10.80, 11.15) 0.13+- 6.54ms (6.43, 6.71) 0.10+-
master 10.60s (10.47, 10.75) 0.11+- 1.10s (1.07, 1.12) 0.02+- 219.39ms (215.74, 222.10) 2.33+- 10.98ms (10.84, 11.15) 0.12+- 6.65ms (6.52, 6.73) 0.08+-
evaluation +0.44%, 0.05s invariant (0.41d, 0.45p, 0.11std) +0.51%, 0.01s invariant (0.24d, 0.66p, 0.02std) +6.25%, 14.62ms slower❌ (2.89d, 0.00p, 4.55std) +0.12%, 0.01ms invariant (0.10d, 0.85p, 0.13std) -1.67%, -0.11ms faster ✓ (-1.24d, 0.04p, 0.09std)
WGLMakie 14.58s (14.29, 14.69) 0.14+- 1.42s (1.40, 1.45) 0.02+- 13.35s (13.15, 13.48) 0.12+- 18.86ms (16.66, 28.55) 4.30+- 1.33s (1.27, 1.43) 0.06+-
master 14.65s (14.45, 14.81) 0.14+- 1.40s (1.38, 1.42) 0.01+- 13.36s (13.30, 13.45) 0.05+- 17.00ms (16.52, 18.47) 0.69+- 1.33s (1.27, 1.39) 0.05+-
evaluation -0.49%, -0.07s invariant (-0.51d, 0.36p, 0.14std) +1.01%, 0.01s invariant (0.85d, 0.14p, 0.02std) -0.12%, -0.02s invariant (-0.18d, 0.75p, 0.09std) +9.88%, 1.86ms noisy🤷‍♀️ (0.60d, 0.30p, 2.50std) +0.07%, 0.0s invariant (0.02d, 0.97p, 0.05std)

@SimonDanisch
Copy link
Member

Will try it out for our next release :) I think we can merge it like this and work from there.

@SimonDanisch SimonDanisch merged commit 792ec81 into master Aug 21, 2023
13 checks passed
@SimonDanisch SimonDanisch deleted the jk/version-tooling branch August 21, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants