Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rticklabelsvisible and thetaticklabelsvisible in PolarAxis #3173

Conversation

Klafyvel
Copy link
Contributor

Description

Hi, I noticed earlier today that rticklabelsvisible and thetaticklabelsvisible were not functional in PolarAxis. Here is a quick fix.

This is my first PR to Makie.jl, so please do not hesitate to tell me if anything's wrong.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@jkrumbiegel jkrumbiegel merged commit 7ad6ad2 into MakieOrg:master Aug 22, 2023
13 checks passed
@jkrumbiegel
Copy link
Member

Thanks!

@Klafyvel Klafyvel deleted the fix-tick-labels-visibility-attribute-polar-axes branch August 22, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants