Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default to theme methods #3214

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Conversation

pepijndevos
Copy link
Contributor

@pepijndevos pepijndevos commented Sep 6, 2023

Description

Fixes #3043

As discussed with @SimonDanisch instead of adding a nothing method, add default arguments

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@pepijndevos pepijndevos mentioned this pull request Sep 6, 2023
7 tasks
@SimonDanisch
Copy link
Member

Thank you! :)
Would it be possible to add some simple sanity tests to:
https://github.com/MakieOrg/Makie.jl/blob/master/test/scenes.jl

@pepijndevos
Copy link
Contributor Author

Of course

@SimonDanisch SimonDanisch merged commit 7ebe960 into MakieOrg:master Sep 7, 2023
13 checks passed
@SimonDanisch
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants