Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement multiple lights and more Light types #3246

Merged
merged 91 commits into from
Oct 30, 2023
Merged

Implement multiple lights and more Light types #3246

merged 91 commits into from
Oct 30, 2023

Commits on Sep 28, 2023

  1. lighting experiments [skip ci]

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    1a67a4d View commit details
    Browse the repository at this point in the history

  2. remove intermediate type, increase number of lights [skip ci]

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    86a63c5 View commit details
    Browse the repository at this point in the history

  3. add directional light, move lightpos transform to cpu

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    13a26d3 View commit details
    Browse the repository at this point in the history

  4. add attenuation

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    e17b154 View commit details
    Browse the repository at this point in the history

  5. hook up interactivity to render_tick [skip ci]

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    f3743c8 View commit details
    Browse the repository at this point in the history

  6. squash parameters into one array

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    7b5a6c6 View commit details
    Browse the repository at this point in the history

  7. add SpotLight [skip ci]

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    c15d90f View commit details
    Browse the repository at this point in the history

  8. reimplement shading [skip ci]

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    614592b View commit details
    Browse the repository at this point in the history

  9. minor cleanup, avoid allocs [skip ci]

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    c250f30 View commit details
    Browse the repository at this point in the history

  10. update RPRMakie, tweak SpotLight

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    7fb1ec5 View commit details
    Browse the repository at this point in the history

  11. switch to smoothstep for SpotLight

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    2a1b8cf View commit details
    Browse the repository at this point in the history

  12. readd old lighting code

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    bbea0a7 View commit details
    Browse the repository at this point in the history

  13. work around for Observables#110

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    f2fdd48 View commit details
    Browse the repository at this point in the history

  14. update shading attribute

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    246ce65 View commit details
    Browse the repository at this point in the history

  15. more shading attribute updates

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    4bab511 View commit details
    Browse the repository at this point in the history

  16. update more shading attributes

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    f62d07f View commit details
    Browse the repository at this point in the history

  17. merge updates into one call, normalize directions

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    7c16e45 View commit details
    Browse the repository at this point in the history

  18. fix directions

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    754f243 View commit details
    Browse the repository at this point in the history

  19. add refimg tests

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    c7c4b38 View commit details
    Browse the repository at this point in the history

  20. fix and test specular reflections

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    2b748ed View commit details
    Browse the repository at this point in the history

  21. update docs

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    20b45b6 View commit details
    Browse the repository at this point in the history

  22. remove specular reflection

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    39604ea View commit details
    Browse the repository at this point in the history

  23. add pollevents in colorbuffer & tweak render_tick priority

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    f564279 View commit details
    Browse the repository at this point in the history

  24. make number of lights adjustable

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    4de2a2e View commit details
    Browse the repository at this point in the history

  25. cleanup some comments, todos, etc

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    58df480 View commit details
    Browse the repository at this point in the history

  26. update NEWS [skip ci]

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    a0ee747 View commit details
    Browse the repository at this point in the history

  27. fixes

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    3c745f6 View commit details
    Browse the repository at this point in the history

  28. fix screen size test

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    7fe5c3d View commit details
    Browse the repository at this point in the history

  29. rework backlight to affect normals and apply to verbose shading

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    dfd26cd View commit details
    Browse the repository at this point in the history

  30. switch to world space lighting

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    2cfc71d View commit details
    Browse the repository at this point in the history

  31. integrate lighting with volume

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    729aea9 View commit details
    Browse the repository at this point in the history

  32. minor cleanup

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    872daa1 View commit details
    Browse the repository at this point in the history

  33. update backlight in other backends

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    dba22ab View commit details
    Browse the repository at this point in the history

  34. minor cleanup [skip ci]

    @ffreyer
    ffreyer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    fc5b654 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. reduce allocations

    @ffreyer
    ffreyer committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    b94fdb6 View commit details
    Browse the repository at this point in the history

  2. fix typo

    @ffreyer
    ffreyer committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    53f92d7 View commit details
    Browse the repository at this point in the history

  3. fix #2985

    @ffreyer
    ffreyer committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    538263c View commit details
    Browse the repository at this point in the history

  4. minor cleanup [skip ci]

    @ffreyer
    ffreyer committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    81e20cc View commit details
    Browse the repository at this point in the history

  5. set default shading based on number of lights

    @ffreyer
    ffreyer committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    5db96a1 View commit details
    Browse the repository at this point in the history

  6. switch shading to enum

    @ffreyer
    ffreyer committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    fd1589a View commit details
    Browse the repository at this point in the history

  7. update some more shading attributes

    @ffreyer
    ffreyer committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    22716d4 View commit details
    Browse the repository at this point in the history

  8. fix WGLMakie errors

    @ffreyer
    ffreyer committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    adf450e View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2023

  1. fix docs

    @ffreyer
    ffreyer committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    a45f34b View commit details
    Browse the repository at this point in the history

  2. derive default shading at plot insertion

    @ffreyer
    ffreyer committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    1d8bb7e View commit details
    Browse the repository at this point in the history

  3. update shading conversion tests

    @ffreyer
    ffreyer committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    cbe2d0a View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. switch to DirectionalLight by default

    @ffreyer
    ffreyer committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    aae5221 View commit details
    Browse the repository at this point in the history

  2. update test

    @ffreyer
    ffreyer committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    1645afd View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. fix specular reflection

    @ffreyer
    ffreyer committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    1df207e View commit details
    Browse the repository at this point in the history

  2. smooth out lighting edge

    @ffreyer
    ffreyer committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    08de7b1 View commit details
    Browse the repository at this point in the history

  3. fix exponent

    @ffreyer
    ffreyer committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    89e27f4 View commit details
    Browse the repository at this point in the history

  4. minor optimization [skip ci]

    @ffreyer
    ffreyer committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    e68846e View commit details
    Browse the repository at this point in the history

  5. update defaults

    @ffreyer
    ffreyer committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    964cab9 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Merge branch 'sd/beta-20' into ff/lighting

    @ffreyer
    ffreyer committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    935c0d0 View commit details
    Browse the repository at this point in the history

  2. fix matcap

    @ffreyer
    ffreyer committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    14b6601 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2023

  1. update docs

    @ffreyer
    ffreyer committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    fbe44f2 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. fix WGLMakie

    @ffreyer
    ffreyer committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    d05dde4 View commit details
    Browse the repository at this point in the history

  2. cleanup print

    @ffreyer
    ffreyer committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    2cb0abd View commit details
    Browse the repository at this point in the history

  3. fix meshscatter [skip ci]

    @ffreyer
    ffreyer committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    0d74694 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. move camera-relative light dir calc to backends

    @ffreyer
    ffreyer committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    4343b62 View commit details
    Browse the repository at this point in the history

  2. add light edge smoothing to WGLMakie

    @ffreyer
    ffreyer committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    9935fb4 View commit details
    Browse the repository at this point in the history

  3. fix error

    @ffreyer
    ffreyer committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    c13f330 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. move scale_matrix to model, fix dir

    @ffreyer
    ffreyer committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    1e4d153 View commit details
    Browse the repository at this point in the history

  2. do not connect transformations in different spaces

    @ffreyer
    ffreyer committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    5a495ce View commit details
    Browse the repository at this point in the history

  3. allow scene to report multiple spaces

    @ffreyer
    ffreyer committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    1f35172 View commit details
    Browse the repository at this point in the history

  4. allow empty lights vectors

    @ffreyer
    ffreyer committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    97ef82e View commit details
    Browse the repository at this point in the history

  5. fix fast lighting with incomplete light setup

    @ffreyer
    ffreyer committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    6dab20b View commit details
    Browse the repository at this point in the history

  6. move docs to references

    @ffreyer
    ffreyer committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    028f883 View commit details
    Browse the repository at this point in the history

  7. minor cleanup

    @ffreyer
    ffreyer committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    dbe8d66 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. fix folder link

    @ffreyer
    ffreyer committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    4f653d3 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. fix typo, try fix docs

    @ffreyer
    ffreyer committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    7ffd4cd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'sd/beta-20' into ff/lighting

    @ffreyer
    ffreyer authored Oct 16, 2023
    Configuration menu
    Copy the full SHA
    9f44af6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'sd/beta-20' into ff/lighting

    @ffreyer
    ffreyer committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    32f8971 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'sd/beta-20' into ff/lighting

    @ffreyer
    ffreyer committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    b6c26f4 View commit details
    Browse the repository at this point in the history

  5. improve example

    @ffreyer
    ffreyer committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    6c37303 View commit details
    Browse the repository at this point in the history

  6. fix missing import

    @ffreyer
    ffreyer committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    60b778f View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Merge branch 'sd/beta-20' into ff/lighting

    @ffreyer
    ffreyer authored Oct 19, 2023
    Configuration menu
    Copy the full SHA
    ca064c4 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. Merge branch 'sd/beta-20' into ff/lighting

    @SimonDanisch
    SimonDanisch authored Oct 26, 2023
    Configuration menu
    Copy the full SHA
    f11a442 View commit details
    Browse the repository at this point in the history

  2. clean up LScene reset_limit, fix test

    @SimonDanisch
    SimonDanisch committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    4f482a7 View commit details
    Browse the repository at this point in the history

  3. fix makie tests

    @SimonDanisch
    SimonDanisch committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    54b73b9 View commit details
    Browse the repository at this point in the history

  4. update WGLMakie bundle

    @SimonDanisch
    SimonDanisch committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    d6ebc56 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. fix nan surface in WGLMakie

    @ffreyer
    ffreyer committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    df67ec8 View commit details
    Browse the repository at this point in the history

  2. consider center when updating camera

    @ffreyer
    ffreyer committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    c839d03 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2023

  1. Merge branch 'sd/beta-20' into ff/lighting

    @ffreyer
    ffreyer committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    3123263 View commit details
    Browse the repository at this point in the history

  2. fix some merge errors

    @ffreyer
    ffreyer committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    7e284e4 View commit details
    Browse the repository at this point in the history

  3. disable centering after explicit camera placement

    @ffreyer
    ffreyer committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    e9c5443 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2023

  1. connect transform_marker to marker/char offsets

    @ffreyer
    ffreyer committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    bff268c View commit details
    Browse the repository at this point in the history

  2. fix axsi3 test (CairoMakie meshscatter transformation)

    @ffreyer
    ffreyer committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    fdbb86a View commit details
    Browse the repository at this point in the history

  3. minor performance tweak

    @ffreyer
    ffreyer committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    9dc792b View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Merge branch 'sd/beta-20' into ff/lighting

    @SimonDanisch
    SimonDanisch authored Oct 30, 2023
    Configuration menu
    Copy the full SHA
    4a00db4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'sd/beta-20' into ff/lighting

    @SimonDanisch
    SimonDanisch authored Oct 30, 2023
    Configuration menu
    Copy the full SHA
    61c596d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'sd/beta-20' into ff/lighting

    @SimonDanisch
    SimonDanisch authored Oct 30, 2023
    Configuration menu
    Copy the full SHA
    1d255de View commit details
    Browse the repository at this point in the history