Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup automatic colorbars for volumeslices #3253

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

ffevotte
Copy link
Contributor

@ffevotte ffevotte commented Sep 25, 2023

Description

Fixes #3251

This PR introduces a specialized extract_colormap(plot::Combined{volumeslices}) method, in an attempt to fix #3251.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

I'm not sure how to test this. I added

  • a call to volumeslices+Colorbar in ReferenceTests/src/tests/figures_and_makielayout.jl, taking contour as a model;
  • a small check in test/makielayout.jl, this time taking barplot as a model.

Is that enough?

@ffevotte
Copy link
Contributor Author

ffevotte commented Sep 25, 2023

Tests seem to fail because the Colorbar for recipes.png test image does not match its reference any more. This is expected since I added a new colorbar to the image, but I'm not sure how to update the reference image accordingly...

@SimonDanisch
Copy link
Member

I updated the reference images!

@SimonDanisch
Copy link
Member

Thank you!

@SimonDanisch SimonDanisch merged commit 389ca5e into MakieOrg:master Sep 27, 2023
14 checks passed
@ffevotte ffevotte deleted the ff/colorbar branch September 27, 2023 17:55
SimonDanisch added a commit that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Multiple colormaps found for plot
2 participants