Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #3275

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Bug fixes #3275

merged 5 commits into from
Oct 4, 2023

Conversation

SimonDanisch
Copy link
Member

@SimonDanisch SimonDanisch commented Oct 4, 2023

Closes #3273, #3266, #3268.
Also fixes a regression for broadcasted_foreach, which stopped working for 0 dim arrays, which introduced a regression in ablines for AoG (AoG turned mapping([0], [1]) into fill(0), fill(1), which worked well with ablines before).

@MakieBot
Copy link
Collaborator

MakieBot commented Oct 4, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 12.23s (12.09, 12.49) 0.15+- 1.19s (1.17, 1.22) 0.02+- 798.25ms (772.61, 839.59) 24.07+- 10.90ms (10.75, 11.02) 0.10+- 144.61ms (142.34, 150.73) 2.87+-
master 12.25s (12.12, 12.45) 0.12+- 1.15s (1.13, 1.18) 0.02+- 792.26ms (775.41, 816.26) 13.91+- 10.98ms (10.79, 11.31) 0.18+- 142.10ms (141.31, 142.67) 0.48+-
evaluation -0.23%, -0.03s invariant (-0.21d, 0.71p, 0.13std) +3.25%, 0.04s slower X (2.43d, 0.00p, 0.02std) +0.75%, 5.98ms invariant (0.30d, 0.58p, 18.99std) -0.79%, -0.09ms invariant (-0.58d, 0.30p, 0.14std) +1.73%, 2.51ms invariant (1.22d, 0.06p, 1.68std)
CairoMakie 11.39s (11.00, 11.64) 0.26+- 1.21s (1.16, 1.24) 0.03+- 228.21ms (218.61, 236.07) 6.07+- 11.28ms (10.87, 11.60) 0.27+- 6.85ms (6.71, 6.99) 0.10+-
master 11.47s (11.00, 11.72) 0.25+- 1.19s (1.14, 1.23) 0.03+- 218.50ms (206.66, 229.48) 9.19+- 11.35ms (10.88, 11.55) 0.24+- 6.84ms (6.69, 6.98) 0.11+-
evaluation -0.68%, -0.08s invariant (-0.30d, 0.58p, 0.26std) +1.80%, 0.02s invariant (0.73d, 0.20p, 0.03std) +4.25%, 9.71ms slower X (1.25d, 0.04p, 7.63std) -0.58%, -0.07ms invariant (-0.26d, 0.63p, 0.25std) +0.10%, 0.01ms invariant (0.07d, 0.90p, 0.10std)
WGLMakie 13.41s (13.15, 13.57) 0.14+- 1.32s (1.24, 1.40) 0.06+- 11.79s (11.70, 11.88) 0.06+- 14.35ms (13.37, 15.28) 0.64+- 1.14s (1.10, 1.19) 0.03+-
master 13.44s (13.37, 13.49) 0.05+- 1.29s (1.23, 1.35) 0.04+- 11.83s (11.68, 12.29) 0.22+- 14.36ms (13.71, 15.06) 0.46+- 1.13s (1.10, 1.18) 0.03+-
evaluation -0.23%, -0.03s invariant (-0.30d, 0.60p, 0.09std) +1.98%, 0.03s invariant (0.49d, 0.38p, 0.05std) -0.33%, -0.04s invariant (-0.25d, 0.66p, 0.14std) -0.11%, -0.02ms invariant (-0.03d, 0.96p, 0.55std) +1.23%, 0.01s invariant (0.44d, 0.43p, 0.03std)

@SimonDanisch SimonDanisch merged commit 8546f2b into master Oct 4, 2023
15 checks passed
@SimonDanisch SimonDanisch deleted the sd/bug-fixes branch October 4, 2023 19:33
SimonDanisch added a commit that referenced this pull request Oct 12, 2023
This reverts commit 8546f2b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

managing colorrange and colorbar in the recipe arrows()
2 participants