Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try old JSServe #3289

Closed
wants to merge 3 commits into from
Closed

try old JSServe #3289

wants to merge 3 commits into from

Conversation

SimonDanisch
Copy link
Member

I have no idea how the new JSServe could make WGLMakie fail only on the CI, but that the failure popped up after the release is pretty suspicious.

@MakieBot
Copy link
Collaborator

MakieBot commented Oct 12, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 11.14s (11.00, 11.25) 0.09+- 1.15s (1.14, 1.17) 0.01+- 822.33ms (802.07, 880.09) 26.20+- 9.54ms (9.47, 9.65) 0.07+- 158.28ms (157.43, 159.01) 0.60+-
master 11.03s (10.95, 11.10) 0.06+- 1.14s (1.13, 1.15) 0.01+- 808.68ms (804.69, 812.10) 2.69+- 9.66ms (9.49, 9.75) 0.09+- 157.53ms (156.11, 158.48) 0.74+-
evaluation +0.98%, 0.11s slower X (1.45d, 0.02p, 0.07std) +0.74%, 0.01s slower X (1.24d, 0.04p, 0.01std) +1.66%, 13.66ms invariant (0.73d, 0.22p, 14.44std) -1.16%, -0.11ms faster ✓ (-1.33d, 0.03p, 0.08std) +0.48%, 0.75ms invariant (1.12d, 0.06p, 0.67std)
CairoMakie 11.20s (11.12, 11.28) 0.06+- 1.17s (1.16, 1.19) 0.01+- 216.84ms (214.86, 221.38) 2.26+- 11.03ms (10.96, 11.21) 0.09+- 6.58ms (6.51, 6.67) 0.06+-
master 11.20s (11.16, 11.27) 0.05+- 1.18s (1.17, 1.21) 0.02+- 219.55ms (214.58, 226.07) 3.97+- 11.07ms (10.97, 11.16) 0.08+- 6.62ms (6.54, 6.71) 0.05+-
evaluation +0.01%, 0.0s invariant (0.01d, 0.99p, 0.05std) -0.78%, -0.01s invariant (-0.65d, 0.25p, 0.01std) -1.25%, -2.72ms invariant (-0.84d, 0.15p, 3.11std) -0.37%, -0.04ms invariant (-0.50d, 0.37p, 0.08std) -0.74%, -0.05ms invariant (-0.89d, 0.12p, 0.05std)
WGLMakie 14.04s (13.91, 14.22) 0.13+- 1.19s (1.17, 1.24) 0.02+- 12.25s (12.06, 12.40) 0.13+- 15.99ms (15.43, 16.94) 0.51+- 1.08s (1.01, 1.15) 0.05+-
master 14.24s (13.95, 14.59) 0.26+- 1.19s (1.16, 1.28) 0.04+- 12.19s (11.95, 12.43) 0.20+- 16.35ms (14.88, 18.05) 1.02+- 1.09s (1.05, 1.12) 0.03+-
evaluation -1.42%, -0.2s invariant (-0.96d, 0.11p, 0.20std) +0.22%, 0.0s invariant (0.07d, 0.89p, 0.03std) +0.45%, 0.06s invariant (0.33d, 0.55p, 0.16std) -2.25%, -0.36ms invariant (-0.44d, 0.43p, 0.77std) -0.93%, -0.01s invariant (-0.24d, 0.67p, 0.04std)

@SimonDanisch SimonDanisch deleted the sd/text-ci-3 branch October 12, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants