Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade three for better error printing in julia #3290

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Conversation

SimonDanisch
Copy link
Member

No description provided.

@MakieBot
Copy link
Collaborator

MakieBot commented Oct 12, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 12.84s (12.42, 13.06) 0.21+- 1.23s (1.18, 1.25) 0.02+- 877.34ms (858.45, 915.68) 19.25+- 11.28ms (11.21, 11.38) 0.07+- 164.76ms (162.53, 167.72) 1.80+-
master 12.81s (12.66, 13.06) 0.14+- 1.22s (1.18, 1.26) 0.03+- 879.27ms (854.19, 892.32) 14.38+- 11.29ms (11.19, 11.39) 0.07+- 165.05ms (163.31, 168.11) 1.66+-
evaluation +0.21%, 0.03s invariant (0.15d, 0.78p, 0.17std) +0.90%, 0.01s invariant (0.42d, 0.45p, 0.03std) -0.22%, -1.93ms invariant (-0.11d, 0.84p, 16.81std) -0.10%, -0.01ms invariant (-0.17d, 0.76p, 0.07std) -0.17%, -0.29ms invariant (-0.16d, 0.76p, 1.73std)
CairoMakie 12.65s (12.56, 12.81) 0.08+- 1.35s (1.33, 1.38) 0.02+- 247.72ms (244.38, 249.41) 1.75+- 12.42ms (12.28, 12.57) 0.09+- 7.42ms (7.27, 7.66) 0.13+-
master 12.70s (12.64, 12.76) 0.05+- 1.35s (1.32, 1.38) 0.02+- 248.93ms (244.55, 252.57) 3.14+- 12.55ms (12.41, 12.73) 0.12+- 7.48ms (7.32, 7.80) 0.17+-
evaluation -0.43%, -0.05s invariant (-0.81d, 0.16p, 0.07std) +0.23%, 0.0s invariant (0.17d, 0.75p, 0.02std) -0.49%, -1.21ms invariant (-0.48d, 0.40p, 2.45std) -1.07%, -0.13ms faster ✓ (-1.28d, 0.03p, 0.10std) -0.84%, -0.06ms invariant (-0.41d, 0.46p, 0.15std)
WGLMakie 12.89s (12.43, 13.82) 0.47+- 1.12s (1.08, 1.19) 0.04+- 12.24s (11.43, 13.01) 0.62+- 16.12ms (13.21, 26.37) 4.57+- 0.89s (0.82, 1.03) 0.06+-
master 12.91s (12.37, 14.16) 0.65+- 1.18s (1.10, 1.36) 0.10+- 12.18s (11.54, 13.49) 0.75+- 14.76ms (13.39, 17.17) 1.36+- 1.07s (0.96, 1.22) 0.08+-
evaluation -0.12%, -0.01s invariant (-0.03d, 0.96p, 0.56std) -5.78%, -0.06s noisy🤷‍♀️ (-0.83d, 0.16p, 0.07std) +0.52%, 0.06s invariant (0.09d, 0.87p, 0.69std) +8.44%, 1.36ms noisy🤷‍♀️ (0.40d, 0.47p, 2.97std) -20.07%, -0.18s faster✅ (-2.49d, 0.00p, 0.07std)

@SimonDanisch SimonDanisch merged commit 2d47976 into master Oct 13, 2023
15 checks passed
@SimonDanisch SimonDanisch deleted the sd/wgl-debug branch October 13, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants