Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combine all compat fixes #3340

Merged
merged 20 commits into from
Oct 31, 2023
Merged

combine all compat fixes #3340

merged 20 commits into from
Oct 31, 2023

Conversation

SimonDanisch
Copy link
Member

No description provided.

CompatHelper Julia and others added 19 commits October 31, 2023 15:37
…-31-16-57-12-944-04150046258' into sd/compat-fixes
…-31-16-56-34-764-01456398121' into sd/compat-fixes
…-31-16-56-28-480-02129180529' into sd/compat-fixes
…-31-16-55-50-151-00587661146' into sd/compat-fixes
…-31-16-55-13-231-00567921884' into sd/compat-fixes
@MakieBot
Copy link
Collaborator

MakieBot commented Oct 31, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 11.38s (11.25, 11.48) 0.09+- 1.16s (1.12, 1.19) 0.02+- 890.10ms (876.67, 944.48) 24.14+- 9.97ms (9.78, 10.09) 0.11+- 160.57ms (157.94, 167.06) 3.05+-
master 11.43s (11.23, 11.81) 0.18+- 1.17s (1.14, 1.23) 0.03+- 766.32ms (746.52, 813.46) 22.26+- 9.89ms (9.77, 10.08) 0.13+- 159.61ms (157.83, 162.09) 1.65+-
evaluation -0.45%, -0.05s invariant (-0.36d, 0.51p, 0.13std) -1.19%, -0.01s invariant (-0.53d, 0.34p, 0.03std) +13.91%, 123.78ms slower❌ (5.33d, 0.00p, 23.20std) +0.71%, 0.07ms invariant (0.57d, 0.30p, 0.12std) +0.60%, 0.96ms invariant (0.39d, 0.48p, 2.35std)
CairoMakie 14.67s (14.58, 14.80) 0.07+- 1.63s (1.61, 1.69) 0.03+- 310.92ms (298.44, 328.95) 11.19+- 16.90ms (16.55, 17.20) 0.26+- 9.38ms (9.09, 9.73) 0.22+-
master 14.77s (14.64, 14.94) 0.10+- 1.65s (1.62, 1.68) 0.02+- 296.27ms (291.40, 301.51) 4.14+- 16.92ms (16.74, 17.02) 0.10+- 9.40ms (9.19, 9.56) 0.13+-
evaluation -0.62%, -0.09s invariant (-1.04d, 0.08p, 0.09std) -1.24%, -0.02s invariant (-0.78d, 0.17p, 0.03std) +4.71%, 14.66ms slower X (1.74d, 0.01p, 7.66std) -0.10%, -0.02ms invariant (-0.08d, 0.88p, 0.18std) -0.16%, -0.02ms invariant (-0.09d, 0.88p, 0.17std)
WGLMakie 16.13s (15.31, 16.72) 0.51+- 1.35s (1.30, 1.41) 0.05+- 15.08s (14.70, 15.46) 0.28+- 18.21ms (16.99, 21.12) 1.40+- 1.13s (1.02, 1.41) 0.13+-
master 15.93s (14.96, 16.69) 0.68+- 1.36s (1.22, 1.49) 0.09+- 14.77s (13.52, 15.60) 0.65+- 17.53ms (16.33, 19.03) 0.83+- 1.08s (1.02, 1.15) 0.05+-
evaluation +1.26%, 0.2s invariant (0.34d, 0.54p, 0.60std) -0.47%, -0.01s invariant (-0.09d, 0.87p, 0.07std) +2.05%, 0.31s invariant (0.61d, 0.28p, 0.47std) +3.73%, 0.68ms invariant (0.59d, 0.30p, 1.12std) +3.88%, 0.04s invariant (0.45d, 0.43p, 0.09std)

@SimonDanisch SimonDanisch merged commit 294a642 into master Oct 31, 2023
15 checks passed
@SimonDanisch SimonDanisch deleted the sd/compat-fixes branch October 31, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants