Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rprmakie fixes #3345

Merged
merged 1 commit into from
Nov 1, 2023
Merged

rprmakie fixes #3345

merged 1 commit into from
Nov 1, 2023

Conversation

SimonDanisch
Copy link
Member

RPRMakie didn't get the full ColorMapping treatment...
Also the renderloop for replace_scene was buggy!

@MakieBot
Copy link
Collaborator

MakieBot commented Nov 1, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 13.82s (13.12, 14.87) 0.70+- 1.39s (1.29, 1.49) 0.08+- 1.07s (0.95, 1.17) 0.08+- 15.20ms (14.11, 15.71) 0.58+- 203.67ms (189.26, 213.48) 7.75+-
master 13.82s (11.99, 14.53) 0.88+- 1.36s (1.23, 1.49) 0.10+- 928.32ms (851.78, 992.23) 49.84+- 15.41ms (14.14, 16.29) 0.68+- 206.02ms (193.54, 213.90) 7.27+-
evaluation +0.06%, 0.01s invariant (0.01d, 0.98p, 0.79std) +2.47%, 0.03s invariant (0.39d, 0.48p, 0.09std) +13.02%, 0.14s slower❌ (2.00d, 0.00p, 0.07std) -1.39%, -0.21ms invariant (-0.34d, 0.54p, 0.63std) -1.15%, -2.35ms invariant (-0.31d, 0.57p, 7.51std)
CairoMakie 12.80s (12.40, 13.09) 0.24+- 1.35s (1.30, 1.40) 0.03+- 243.37ms (237.62, 250.87) 4.57+- 12.48ms (12.26, 12.79) 0.22+- 7.35ms (7.17, 7.45) 0.11+-
master 12.82s (12.58, 13.27) 0.22+- 1.33s (1.29, 1.38) 0.03+- 258.58ms (242.37, 272.17) 8.90+- 12.48ms (12.08, 12.86) 0.24+- 7.39ms (7.24, 7.60) 0.15+-
evaluation -0.18%, -0.02s invariant (-0.10d, 0.85p, 0.23std) +0.98%, 0.01s invariant (0.41d, 0.46p, 0.03std) -6.25%, -15.21ms faster✅ (-2.15d, 0.00p, 6.73std) +0.03%, 0.0ms invariant (0.02d, 0.97p, 0.23std) -0.55%, -0.04ms invariant (-0.31d, 0.57p, 0.13std)
WGLMakie 9.59s (9.52, 9.64) 0.04+- 874.30ms (847.28, 894.93) 14.52+- 9.68s (9.62, 9.74) 0.05+- 9.27ms (9.00, 10.36) 0.48+- 497.05ms (486.62, 512.65) 9.15+-
master 9.52s (9.43, 9.59) 0.05+- 875.95ms (864.71, 884.99) 7.07+- 9.71s (9.68, 9.79) 0.04+- 9.07ms (8.96, 9.17) 0.07+- 491.60ms (480.61, 507.94) 8.42+-
evaluation +0.74%, 0.07s slower X (1.56d, 0.01p, 0.05std) -0.19%, -1.66ms invariant (-0.15d, 0.79p, 10.79std) -0.39%, -0.04s invariant (-0.93d, 0.11p, 0.04std) +2.11%, 0.2ms invariant (0.57d, 0.33p, 0.28std) +1.10%, 5.45ms invariant (0.62d, 0.27p, 8.78std)

@SimonDanisch SimonDanisch merged commit f48d25e into master Nov 1, 2023
15 checks passed
@SimonDanisch SimonDanisch deleted the sd/fix-rprmakie branch November 1, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants