Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce warnings for ImageLike deprecation #3396

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

jkrumbiegel
Copy link
Member

  • remove LinRanges in Colorbar image
  • fix typo and add depwarn test for ImageLike

@MakieBot
Copy link
Collaborator

MakieBot commented Nov 21, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 3.38s (3.35, 3.40) 0.02+- 390.00ms (384.40, 397.52) 4.03+- 469.26ms (465.59, 476.30) 3.51+- 7.54ms (7.27, 8.21) 0.31+- 25.44ms (25.39, 25.56) 0.06+-
master 3.41s (3.38, 3.44) 0.02+- 513.34ms (505.36, 521.51) 6.07+- 474.51ms (465.78, 510.35) 15.93+- 7.46ms (7.38, 7.52) 0.04+- 25.45ms (25.31, 25.62) 0.10+-
evaluation 1.01x faster ✓, -0.03s (-1.56d, 0.01p, 0.02std) 1.32x faster✅, -123.34ms (-23.96d, 0.00p, 5.05std) 1.01x invariant, -5.25ms (-0.46d, 0.42p, 9.72std) 0.99x invariant, 0.08ms (0.37d, 0.52p, 0.18std) 1.00x invariant, -0.0ms (-0.06d, 0.91p, 0.08std)
CairoMakie 3.10s (3.05, 3.25) 0.07+- 358.03ms (342.77, 391.58) 16.90+- 153.19ms (144.27, 165.25) 8.75+- 7.97ms (7.58, 8.86) 0.42+- 608.15μs (600.39, 623.92) 8.01+-
master 3.09s (3.06, 3.13) 0.02+- 350.76ms (341.18, 365.93) 10.04+- 149.22ms (145.37, 153.02) 3.04+- 7.72ms (7.64, 7.76) 0.05+- 601.57μs (599.79, 603.67) 1.56+-
evaluation 1.00x invariant, 0.01s (0.20d, 0.72p, 0.05std) 0.98x invariant, 7.27ms (0.52d, 0.35p, 13.47std) 0.97x invariant, 3.97ms (0.61d, 0.29p, 5.90std) 0.97x invariant, 0.25ms (0.84d, 0.17p, 0.24std) 0.99x invariant, 6.58μs (1.14d, 0.07p, 4.78std)
WGLMakie 3.63s (3.61, 3.69) 0.03+- 513.59ms (327.45, 546.52) 82.11+- 8.70s (8.67, 8.73) 0.02+- 9.73ms (9.41, 10.71) 0.44+- 70.71ms (67.56, 77.60) 3.97+-
master 3.62s (3.59, 3.66) 0.03+- 331.20ms (328.43, 334.69) 2.05+- 8.80s (8.63, 8.90) 0.11+- 9.55ms (9.43, 9.66) 0.07+- 72.68ms (67.06, 78.72) 4.85+-
evaluation 1.00x invariant, 0.01s (0.32d, 0.56p, 0.03std) 0.64x slower❌, 182.39ms (3.14d, 0.00p, 42.08std) 1.01x faster ✓, -0.1s (-1.34d, 0.04p, 0.06std) 0.98x invariant, 0.18ms (0.58d, 0.32p, 0.26std) 1.03x invariant, -1.97ms (-0.45d, 0.42p, 4.41std)

@SimonDanisch SimonDanisch merged commit 2ba82bb into master Nov 21, 2023
14 checks passed
@SimonDanisch SimonDanisch deleted the jk/reduce-imagelike-warnings branch November 21, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants