-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to reduce edge artifacts in scatter (text, lines) #3408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compile Times benchmarkNote, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running: using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
|
This was referenced Nov 24, 2023
* add naive depth sorting for scatter & text * add depthsorting docs * update news
ffreyer
changed the title
Add fxaa mode to scatter (text, lines)
Add options to reduce edge artifacts in scatter (text, lines)
Dec 20, 2023
ffreyer
added
the
GLMakie
This relates to GLMakie.jl, the OpenGL backend for Makie.
label
Dec 20, 2023
SimonDanisch
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes/Improves https://discourse.julialang.org/t/hide-stroke-in-3d-scatter-using-makie-jl/106383
Adjusts the shader to not do AA via sdf data when
fxaa = true
. This avoids generating transparent pixels from AA, which generate artifacts based on render order.So it allows you to get rid of white outlines in 3D scatters
at the cost of marker quality/detail
by setting
fxaa = true
.From #3432:
Adds
depthsorting::Bool
as a hidden attribute. Setting it totrue
results in scatter markers getting sorted on the CPU, making them render in a non-artifacting order:This only works between markers of the same plot call. If markers from another scatter call or another plot object is involved artifacts may reappear. Unlike the fxaa solution this does not degrade quality though:
Type of change
Checklist