Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write figure sizes into html img tags #3448

Merged
merged 11 commits into from
Dec 6, 2023
Merged

Conversation

jkrumbiegel
Copy link
Member

No description provided.

@MakieBot
Copy link
Collaborator

MakieBot commented Dec 6, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 3.62s (3.55, 3.71) 0.06+- 406.13ms (401.45, 423.05) 7.71+- 493.46ms (476.78, 528.44) 17.89+- 7.44ms (7.30, 7.64) 0.11+- 25.86ms (25.66, 26.03) 0.14+-
master 3.60s (3.54, 3.69) 0.05+- 391.93ms (321.95, 429.11) 46.71+- 486.72ms (476.73, 498.36) 7.30+- 7.34ms (7.24, 7.58) 0.11+- 26.12ms (25.95, 26.41) 0.18+-
evaluation 1.00x invariant, 0.02s (0.32d, 0.56p, 0.05std) 0.97x invariant, 14.21ms (0.42d, 0.46p, 27.21std) 0.99x invariant, 6.74ms (0.49d, 0.38p, 12.59std) 0.99x invariant, 0.1ms (0.89d, 0.12p, 0.11std) 1.01x faster ✓, -0.27ms (-1.64d, 0.01p, 0.16std)
CairoMakie 3.02s (2.99, 3.05) 0.02+- 320.35ms (316.15, 324.65) 2.63+- 142.17ms (140.76, 143.20) 0.97+- 7.04ms (7.01, 7.07) 0.02+- 594.84μs (591.42, 600.52) 2.98+-
master 3.00s (2.98, 3.02) 0.01+- 323.52ms (319.06, 326.70) 3.21+- 141.98ms (139.23, 143.58) 1.44+- 7.07ms (7.04, 7.11) 0.03+- 599.08μs (595.41, 602.41) 2.46+-
evaluation 0.99x slower X, 0.02s (1.45d, 0.02p, 0.02std) 1.01x invariant, -3.17ms (-1.08d, 0.07p, 2.92std) 1.00x invariant, 0.19ms (0.15d, 0.78p, 1.21std) 1.00x faster ✓, -0.03ms (-1.35d, 0.03p, 0.02std) 1.01x faster ✓, -4.23μs (-1.55d, 0.01p, 2.72std)
WGLMakie 3.92s (3.89, 3.95) 0.02+- 335.21ms (316.18, 351.21) 14.99+- 8.78s (8.73, 8.88) 0.05+- 9.56ms (9.38, 9.88) 0.17+- 70.21ms (68.65, 76.61) 2.86+-
master 3.91s (3.86, 4.08) 0.08+- 328.44ms (320.89, 342.48) 7.19+- 8.84s (8.74, 8.92) 0.07+- 9.78ms (9.47, 11.05) 0.57+- 72.33ms (69.01, 77.01) 3.56+-
evaluation 1.00x invariant, 0.01s (0.12d, 0.83p, 0.05std) 0.98x invariant, 6.77ms (0.58d, 0.31p, 11.09std) 1.01x invariant, -0.06s (-0.93d, 0.11p, 0.06std) 1.02x invariant, -0.22ms (-0.53d, 0.36p, 0.37std) 1.03x invariant, -2.12ms (-0.66d, 0.24p, 3.21std)

@jkrumbiegel jkrumbiegel merged commit 98bd168 into master Dec 6, 2023
15 checks passed
@jkrumbiegel jkrumbiegel deleted the jk/docs-image-sizes branch December 6, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants