Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass update through record/Record/VideoStream #3482

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

SimonDanisch
Copy link
Member

No description provided.

@MakieBot
Copy link
Collaborator

MakieBot commented Dec 18, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 3.52s (3.49, 3.56) 0.02+- 354.93ms (308.36, 390.42) 42.57+- 470.09ms (468.17, 472.50) 1.42+- 7.24ms (7.17, 7.34) 0.07+- 25.48ms (25.33, 25.62) 0.12+-
master 3.51s (3.47, 3.54) 0.03+- 367.79ms (308.40, 396.86) 39.92+- 480.26ms (470.17, 517.04) 17.69+- 7.20ms (7.14, 7.30) 0.06+- 25.41ms (25.33, 25.46) 0.05+-
evaluation 1.00x invariant, 0.01s (0.56d, 0.32p, 0.02std) 1.04x invariant, -12.86ms (-0.31d, 0.57p, 41.25std) 1.02x invariant, -10.17ms (-0.81d, 0.18p, 9.55std) 1.00x invariant, 0.04ms (0.56d, 0.32p, 0.06std) 1.00x invariant, 0.07ms (0.76d, 0.19p, 0.08std)
CairoMakie 3.09s (3.07, 3.11) 0.01+- 320.12ms (317.44, 323.00) 1.95+- 142.84ms (141.26, 143.57) 0.80+- 7.32ms (7.26, 7.47) 0.08+- 608.12μs (602.74, 618.43) 5.40+-
master 3.09s (3.05, 3.20) 0.05+- 321.84ms (319.29, 325.27) 2.08+- 143.31ms (139.85, 148.76) 2.70+- 7.33ms (7.14, 7.49) 0.11+- 607.53μs (598.08, 632.12) 11.60+-
evaluation 1.00x invariant, -0.01s (-0.15d, 0.79p, 0.03std) 1.01x invariant, -1.72ms (-0.85d, 0.14p, 2.02std) 1.00x invariant, -0.47ms (-0.24d, 0.67p, 1.75std) 1.00x invariant, -0.01ms (-0.12d, 0.83p, 0.10std) 1.00x invariant, 0.59μs (0.07d, 0.91p, 8.50std)
WGLMakie
master
evaluation

@SimonDanisch SimonDanisch merged commit 61bc20a into master Dec 18, 2023
15 checks passed
@SimonDanisch SimonDanisch deleted the sd/fix-record-update branch December 18, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants