-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add highlevel gui + auto legend/colorbar #3491
base: master
Are you sure you want to change the base?
Conversation
Compile Times benchmarkNote, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running: using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
|
f, ax, pl = GUI(series(rand(7, 20)); legend=(position=:lt, title="legend")) | ||
``` | ||
""" | ||
function GUI(faxpl::Makie.FigureAxisPlot; legend=(;), colorbar=(;)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also add a method which accepts a figure, so people can "opt-in" to displaying their figures (or maybe even Scenes) in this GUI by default, perhaps by setting a switch in activate!?
This is a proposal for an easy way to add a highlevel GUI and auto legend/colorbar, without any changes to the internal plotting pipeline.
This makes the implementation pretty straightforward and easy to change going forward, at the slight expanse of discoverability & usability.
This works by just wrapping a plot call into
GUI(plot(...))
, which will then create a GUI like this:TODOs:
GUI
?