Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stroke and glow to WGLMakie #3518

Merged
merged 7 commits into from
Dec 29, 2023
Merged

Add stroke and glow to WGLMakie #3518

merged 7 commits into from
Dec 29, 2023

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Dec 28, 2023

Description

Fixes #3279

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added Activated reference image tests for new plotting functions, recipes, visual options, etc.

@ffreyer ffreyer added the WGLMakie This relates to WGLMakie.jl, the Web-based WebGL backend for Makie. label Dec 28, 2023
@MakieBot
Copy link
Collaborator

MakieBot commented Dec 28, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 3.45s (3.41, 3.51) 0.03+- 387.58ms (380.25, 398.19) 6.47+- 470.21ms (465.74, 475.09) 2.79+- 7.24ms (7.11, 7.36) 0.09+- 25.56ms (25.31, 25.77) 0.16+-
master 3.42s (3.38, 3.46) 0.03+- 386.87ms (376.48, 399.35) 7.65+- 476.20ms (463.54, 515.88) 17.87+- 7.13ms (7.02, 7.27) 0.08+- 25.43ms (25.25, 25.67) 0.14+-
evaluation 0.99x invariant, 0.03s (1.02d, 0.08p, 0.03std) 1.00x invariant, 0.71ms (0.10d, 0.85p, 7.06std) 1.01x invariant, -5.99ms (-0.47d, 0.41p, 10.33std) 0.98x slower X, 0.12ms (1.33d, 0.03p, 0.09std) 0.99x invariant, 0.13ms (0.84d, 0.14p, 0.15std)
CairoMakie 3.01s (3.00, 3.03) 0.01+- 313.83ms (310.18, 315.69) 1.74+- 139.15ms (137.76, 139.67) 0.66+- 7.11ms (7.05, 7.16) 0.04+- 600.27μs (597.73, 605.57) 2.93+-
master 2.99s (2.97, 3.02) 0.02+- 313.03ms (310.39, 315.78) 2.37+- 138.74ms (137.47, 139.74) 0.98+- 7.02ms (6.94, 7.06) 0.04+- 600.38μs (597.58, 602.04) 1.70+-
evaluation 0.99x slower X, 0.02s (1.39d, 0.02p, 0.01std) 1.00x invariant, 0.8ms (0.38d, 0.49p, 2.06std) 1.00x invariant, 0.42ms (0.50d, 0.37p, 0.82std) 0.99x slower X, 0.08ms (1.97d, 0.00p, 0.04std) 1.00x invariant, -0.12μs (-0.05d, 0.93p, 2.32std)
WGLMakie 3.91s (3.84, 3.97) 0.05+- 349.86ms (335.92, 359.42) 8.77+- 9.68s (9.46, 9.88) 0.15+- 9.95ms (9.62, 10.24) 0.23+- 74.09ms (68.66, 79.22) 4.21+-
master 3.89s (3.80, 3.96) 0.06+- 349.79ms (338.06, 363.88) 8.89+- 9.70s (9.55, 9.88) 0.11+- 10.21ms (9.63, 10.85) 0.44+- 71.64ms (67.98, 76.47) 3.11+-
evaluation 0.99x invariant, 0.02s (0.38d, 0.49p, 0.06std) 1.00x invariant, 0.07ms (0.01d, 0.99p, 8.83std) 1.00x invariant, -0.02s (-0.17d, 0.76p, 0.13std) 1.03x invariant, -0.25ms (-0.71d, 0.22p, 0.34std) 0.97x invariant, 2.45ms (0.66d, 0.24p, 3.66std)

@ffreyer ffreyer marked this pull request as ready for review December 28, 2023 17:31
@SimonDanisch SimonDanisch merged commit cdade9b into master Dec 29, 2023
16 checks passed
@SimonDanisch SimonDanisch deleted the ff/scatter_stroke branch December 29, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WGLMakie This relates to WGLMakie.jl, the Web-based WebGL backend for Makie.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stroke support for scatter() in WGLMakie
3 participants