Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup three display and fix #3517 & #3503 #3522

Merged
merged 3 commits into from
Dec 29, 2023
Merged

Conversation

SimonDanisch
Copy link
Member

Closes #3517. The issue was two fold, and both about not correctly re-using the WGLMakie.Screen.
Took the chance to clean up the old ThreeDisplay which didn't make much sense anymore.

@MakieBot
Copy link
Collaborator

MakieBot commented Dec 29, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 3.60s (3.49, 3.70) 0.07+- 415.49ms (401.07, 429.39) 10.01+- 503.61ms (492.77, 522.63) 9.84+- 7.59ms (7.33, 7.70) 0.14+- 26.20ms (25.87, 26.40) 0.22+-
master 3.60s (3.53, 3.70) 0.06+- 412.91ms (396.60, 430.70) 12.01+- 495.49ms (484.22, 518.57) 11.61+- 7.57ms (7.48, 7.67) 0.06+- 26.18ms (26.05, 26.29) 0.09+-
evaluation 1.00x invariant, 0.01s (0.13d, 0.81p, 0.06std) 0.99x invariant, 2.58ms (0.23d, 0.67p, 11.01std) 0.98x invariant, 8.12ms (0.75d, 0.18p, 10.72std) 1.00x invariant, 0.01ms (0.13d, 0.81p, 0.10std) 1.00x invariant, 0.02ms (0.09d, 0.87p, 0.15std)
CairoMakie 3.02s (3.00, 3.09) 0.03+- 318.39ms (315.36, 319.96) 1.72+- 141.05ms (139.91, 144.78) 1.70+- 7.14ms (7.08, 7.22) 0.05+- 604.99μs (599.32, 616.46) 5.43+-
master 3.02s (3.01, 3.08) 0.02+- 318.47ms (314.61, 321.61) 2.11+- 140.35ms (138.50, 142.03) 1.09+- 7.19ms (7.04, 7.29) 0.08+- 604.65μs (598.35, 614.08) 5.06+-
evaluation 1.00x invariant, -0.0s (-0.00d, 0.99p, 0.03std) 1.00x invariant, -0.08ms (-0.04d, 0.94p, 1.92std) 1.00x invariant, 0.7ms (0.49d, 0.38p, 1.40std) 1.01x invariant, -0.05ms (-0.73d, 0.20p, 0.07std) 1.00x invariant, 0.35μs (0.07d, 0.90p, 5.25std)
WGLMakie 3.71s (3.67, 3.81) 0.05+- 455.96ms (325.87, 554.98) 117.93+- 9.17s (9.01, 9.45) 0.15+- 9.30ms (9.08, 9.68) 0.20+- 71.69ms (67.89, 79.65) 5.38+-
master 3.75s (3.69, 3.85) 0.06+- 330.63ms (322.79, 333.85) 3.75+- 9.21s (9.08, 9.37) 0.10+- 9.23ms (9.10, 9.45) 0.11+- 71.41ms (67.11, 77.04) 4.09+-
evaluation 1.01x invariant, -0.04s (-0.77d, 0.17p, 0.05std) 0.73x slower❌, 125.33ms (1.50d, 0.03p, 60.84std) 1.00x invariant, -0.04s (-0.34d, 0.54p, 0.12std) 0.99x invariant, 0.07ms (0.46d, 0.41p, 0.16std) 1.00x invariant, 0.28ms (0.06d, 0.91p, 4.74std)

@SimonDanisch SimonDanisch linked an issue Dec 29, 2023 that may be closed by this pull request
2 tasks
@SimonDanisch SimonDanisch changed the title cleanup three display and fix #3517 cleanup three display and fix #3517 & #3503 Dec 29, 2023
@SimonDanisch SimonDanisch merged commit 40f502b into master Dec 29, 2023
16 checks passed
@SimonDanisch SimonDanisch deleted the sd/wglmakie-fixes branch December 29, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WGLMakie error in window event callback Lines in WGLMakie are not inspectable
2 participants