Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Makie.automatic in lighting docs #3537

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Use Makie.automatic in lighting docs #3537

merged 2 commits into from
Jan 12, 2024

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Jan 8, 2024

Description

Fixes #3495

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added or changed relevant sections in the documentation

@MakieBot
Copy link
Collaborator

MakieBot commented Jan 8, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 3.51s (3.40, 3.63) 0.08+- 401.22ms (378.10, 444.30) 21.93+- 482.38ms (461.88, 538.04) 26.53+- 7.24ms (7.02, 7.36) 0.11+- 25.67ms (25.27, 26.00) 0.25+-
master 3.51s (3.40, 3.58) 0.06+- 410.96ms (400.43, 426.63) 9.75+- 473.59ms (464.19, 482.10) 6.69+- 7.26ms (7.09, 7.53) 0.14+- 25.79ms (25.60, 26.06) 0.18+-
evaluation 1.00x invariant, -0.01s (-0.10d, 0.85p, 0.07std) 1.02x invariant, -9.74ms (-0.57d, 0.31p, 15.84std) 0.98x invariant, 8.79ms (0.45d, 0.42p, 16.61std) 1.00x invariant, -0.02ms (-0.18d, 0.74p, 0.13std) 1.00x invariant, -0.12ms (-0.57d, 0.31p, 0.21std)
CairoMakie 3.32s (3.21, 3.43) 0.07+- 376.60ms (348.97, 402.07) 19.71+- 159.06ms (149.84, 168.77) 6.48+- 8.12ms (7.95, 8.40) 0.17+- 631.73μs (620.28, 640.05) 7.74+-
master 3.35s (3.28, 3.39) 0.04+- 381.65ms (357.27, 406.28) 14.97+- 160.79ms (156.49, 166.00) 3.16+- 8.35ms (8.00, 8.54) 0.20+- 640.26μs (629.65, 653.12) 8.12+-
evaluation 1.01x invariant, -0.02s (-0.37d, 0.51p, 0.05std) 1.01x invariant, -5.05ms (-0.29d, 0.60p, 17.34std) 1.01x invariant, -1.73ms (-0.34d, 0.54p, 4.82std) 1.03x faster ✓, -0.23ms (-1.23d, 0.04p, 0.18std) 1.01x invariant, -8.53μs (-1.07d, 0.07p, 7.93std)
WGLMakie 3.65s (3.63, 3.68) 0.02+- 317.74ms (313.77, 321.03) 2.55+- 8.76s (8.71, 8.81) 0.04+- 9.07ms (9.01, 9.13) 0.05+- 69.90ms (67.22, 75.82) 2.96+-
master 3.65s (3.62, 3.67) 0.01+- 317.22ms (316.08, 318.11) 0.70+- 8.78s (8.74, 8.82) 0.03+- 9.42ms (8.89, 11.48) 0.91+- 68.40ms (66.53, 71.89) 1.75+-
evaluation 1.00x invariant, 0.01s (0.35d, 0.52p, 0.02std) 1.00x invariant, 0.52ms (0.28d, 0.62p, 1.62std) 1.00x invariant, -0.03s (-0.76d, 0.18p, 0.03std) 1.04x invariant, -0.35ms (-0.55d, 0.34p, 0.48std) 0.98x invariant, 1.5ms (0.62d, 0.27p, 2.35std)

@SimonDanisch SimonDanisch merged commit 0ab26ca into master Jan 12, 2024
17 checks passed
@SimonDanisch SimonDanisch deleted the ff/lighting branch January 12, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shading automatic doesn't work as suggested by warning.
3 participants