Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for IntervalArithmetic to 0.22, (keep existing compat) #3601

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 5, 2024

This pull request changes the compat entry for the IntervalArithmetic package from <0.22.6 to <0.22.6, 0.22.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@github-actions github-actions bot force-pushed the compathelper/new_version/2024-02-05-00-07-36-103-00087935471 branch from cf5cba8 to 408add9 Compare February 5, 2024 00:07
@asinghvi17 asinghvi17 closed this Feb 6, 2024
@asinghvi17 asinghvi17 reopened this Feb 6, 2024
@MakieBot
Copy link
Collaborator

MakieBot commented Feb 6, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 3.44s (3.43, 3.47) 0.02+- 377.94ms (310.61, 392.79) 29.78+- 467.56ms (465.84, 469.42) 1.49+- 7.19ms (7.15, 7.23) 0.03+- 25.34ms (25.31, 25.38) 0.02+-
master 3.46s (3.39, 3.50) 0.04+- 388.77ms (309.96, 405.85) 35.02+- 475.37ms (466.14, 513.05) 16.75+- 7.23ms (7.14, 7.30) 0.05+- 25.35ms (25.29, 25.43) 0.04+-
evaluation 1.00x invariant, -0.01s (-0.40d, 0.48p, 0.03std) 1.03x invariant, -10.83ms (-0.33d, 0.54p, 32.40std) 1.02x invariant, -7.82ms (-0.66d, 0.26p, 9.12std) 1.01x invariant, -0.04ms (-0.99d, 0.10p, 0.04std) 1.00x invariant, -0.01ms (-0.27d, 0.63p, 0.03std)
CairoMakie 3.07s (3.04, 3.12) 0.03+- 322.24ms (318.13, 332.44) 4.68+- 140.77ms (139.14, 144.50) 1.84+- 7.30ms (7.26, 7.42) 0.06+- 623.83μs (617.69, 627.59) 3.37+-
master 3.05s (3.02, 3.08) 0.02+- 320.42ms (316.09, 322.45) 2.10+- 141.15ms (139.03, 142.16) 1.09+- 7.23ms (7.17, 7.27) 0.03+- 624.00μs (619.38, 629.40) 3.06+-
evaluation 0.99x invariant, 0.02s (0.73d, 0.20p, 0.03std) 0.99x invariant, 1.82ms (0.50d, 0.37p, 3.39std) 1.00x invariant, -0.39ms (-0.26d, 0.64p, 1.46std) 0.99x slower X, 0.07ms (1.44d, 0.02p, 0.04std) 1.00x invariant, -0.16μs (-0.05d, 0.93p, 3.22std)
WGLMakie 3.70s (3.63, 3.91) 0.10+- 323.67ms (317.30, 352.70) 12.84+- 8.92s (8.75, 9.47) 0.26+- 9.21ms (8.98, 9.90) 0.32+- 72.29ms (67.37, 76.00) 3.14+-
master 3.73s (3.60, 3.85) 0.10+- 425.35ms (319.26, 587.48) 120.76+- 9.02s (8.75, 9.34) 0.29+- 9.35ms (8.93, 10.67) 0.62+- 74.31ms (67.02, 91.43) 8.36+-
evaluation 1.01x invariant, -0.03s (-0.27d, 0.62p, 0.10std) 1.31x noisy🤷‍♀️, -101.68ms (-1.18d, 0.07p, 66.80std) 1.01x invariant, -0.1s (-0.36d, 0.51p, 0.27std) 1.02x invariant, -0.14ms (-0.29d, 0.60p, 0.47std) 1.03x invariant, -2.02ms (-0.32d, 0.57p, 5.75std)

@SimonDanisch SimonDanisch added the skip-changelog Skips changelog enforcer label Feb 7, 2024
I only added IntervalArithmetic to set a compat bound on it
@SimonDanisch SimonDanisch merged commit f92b260 into master Feb 7, 2024
20 checks passed
@SimonDanisch SimonDanisch deleted the compathelper/new_version/2024-02-05-00-07-36-103-00087935471 branch February 7, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips changelog enforcer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants