Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ScatterLines a PointBased plot #3603

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Conversation

asinghvi17
Copy link
Member

@asinghvi17 asinghvi17 commented Feb 5, 2024

Description

I noticed that scatterlines did not have a conversion trait established, so this PR is a quick fix for that.

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@MakieBot
Copy link
Collaborator

MakieBot commented Feb 5, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 3.50s (3.48, 3.52) 0.01+- 390.64ms (386.62, 399.28) 4.13+- 472.64ms (465.08, 498.96) 11.84+- 7.26ms (7.19, 7.32) 0.05+- 25.43ms (25.33, 25.53) 0.06+-
master 3.46s (3.43, 3.51) 0.03+- 391.48ms (387.01, 394.31) 2.44+- 479.35ms (464.98, 535.81) 25.05+- 7.25ms (7.16, 7.30) 0.06+- 25.46ms (25.35, 25.76) 0.14+-
evaluation 0.99x slower X, 0.04s (1.57d, 0.02p, 0.02std) 1.00x invariant, -0.84ms (-0.25d, 0.65p, 3.29std) 1.01x invariant, -6.71ms (-0.34d, 0.54p, 18.45std) 1.00x invariant, 0.01ms (0.21d, 0.70p, 0.05std) 1.00x invariant, -0.04ms (-0.34d, 0.54p, 0.10std)
CairoMakie 3.16s (3.05, 3.34) 0.10+- 340.19ms (318.27, 386.27) 28.86+- 147.04ms (139.25, 161.11) 9.14+- 7.32ms (7.12, 7.55) 0.16+- 628.71μs (620.46, 637.03) 6.52+-
master 3.10s (3.03, 3.20) 0.07+- 326.09ms (319.01, 345.08) 10.29+- 144.68ms (139.91, 155.61) 5.57+- 7.32ms (7.13, 7.50) 0.12+- 619.36μs (614.85, 623.90) 3.37+-
evaluation 0.98x invariant, 0.07s (0.73d, 0.20p, 0.09std) 0.96x invariant, 14.09ms (0.65d, 0.26p, 19.58std) 0.98x invariant, 2.36ms (0.31d, 0.57p, 7.35std) 1.00x invariant, 0.0ms (0.01d, 0.99p, 0.14std) 0.99x slower X, 9.35μs (1.80d, 0.01p, 4.94std)
WGLMakie 3.78s (3.69, 4.02) 0.11+- 328.56ms (316.45, 369.98) 18.91+- 9.04s (8.75, 9.72) 0.33+- 9.36ms (9.11, 9.62) 0.20+- 71.37ms (67.79, 81.24) 4.64+-
master 3.81s (3.70, 3.97) 0.10+- 334.02ms (315.99, 355.20) 15.38+- 9.09s (8.77, 9.68) 0.29+- 9.44ms (9.07, 10.24) 0.39+- 74.20ms (68.99, 83.58) 5.59+-
evaluation 1.01x invariant, -0.03s (-0.27d, 0.62p, 0.11std) 1.02x invariant, -5.46ms (-0.32d, 0.56p, 17.14std) 1.00x invariant, -0.04s (-0.14d, 0.80p, 0.31std) 1.01x invariant, -0.08ms (-0.25d, 0.65p, 0.29std) 1.04x invariant, -2.83ms (-0.55d, 0.32p, 5.12std)

@asinghvi17 asinghvi17 merged commit 5532358 into master Feb 6, 2024
17 checks passed
@asinghvi17 asinghvi17 deleted the as/scatterlines_pointbased branch February 6, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants