From b3bd90efcad53789aa5132213e2ecd9d9594bbc9 Mon Sep 17 00:00:00 2001 From: Anshul Singhvi Date: Mon, 5 Feb 2024 16:29:15 +0530 Subject: [PATCH 1/2] Make ScatterLines a PointBased plot --- src/basic_recipes/scatterlines.jl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/basic_recipes/scatterlines.jl b/src/basic_recipes/scatterlines.jl index 6e51549846f..cc2e02d4ec8 100644 --- a/src/basic_recipes/scatterlines.jl +++ b/src/basic_recipes/scatterlines.jl @@ -28,6 +28,8 @@ $(ATTRIBUTES) ) end +conversion_trait(::Type{<: ScatterLines}) = PointBased() + function plot!(p::Plot{scatterlines, <:NTuple{N, Any}}) where N From 1c4a2025b3c0c77f55d7550af323fd086c115857 Mon Sep 17 00:00:00 2001 From: Anshul Singhvi Date: Mon, 5 Feb 2024 16:37:29 +0530 Subject: [PATCH 2/2] Update NEWS.md --- NEWS.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/NEWS.md b/NEWS.md index 3d05e3e0d0e..734aebf3d54 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,5 +1,9 @@ # News +## master + +- Gave the `scatterlines` recipe a `PointBased` conversion trait (previously not defined) [#3603](https://github.com/MakieOrg/Makie.jl/pull/3603) + ## 0.20.7 - Equalized alignment point of mirrored ticks to that of normal ticks [#3598](https://github.com/MakieOrg/Makie.jl/pull/3598).