Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce changelog #3606

Merged
merged 5 commits into from
Feb 6, 2024
Merged

Enforce changelog #3606

merged 5 commits into from
Feb 6, 2024

Conversation

jkrumbiegel
Copy link
Member

  • rename NEWS to CHANGELOG and add enforcer action
  • adjust headings to keepachangelog format
  • add links

@jkrumbiegel jkrumbiegel added the skip-changelog Skips changelog enforcer label Feb 6, 2024
@MakieBot
Copy link
Collaborator

MakieBot commented Feb 6, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 3.53s (3.45, 3.59) 0.06+- 413.79ms (331.49, 455.52) 44.35+- 478.89ms (474.06, 487.17) 5.59+- 7.52ms (7.41, 7.68) 0.09+- 25.97ms (25.86, 26.08) 0.08+-
master 3.58s (3.53, 3.63) 0.04+- 418.17ms (399.70, 432.49) 10.62+- 491.51ms (476.28, 529.76) 19.89+- 7.51ms (7.42, 7.73) 0.10+- 26.02ms (25.89, 26.14) 0.08+-
evaluation 1.01x invariant, -0.05s (-1.04d, 0.08p, 0.05std) 1.01x invariant, -4.39ms (-0.14d, 0.81p, 27.49std) 1.03x invariant, -12.62ms (-0.86d, 0.15p, 12.74std) 1.00x invariant, 0.01ms (0.13d, 0.81p, 0.09std) 1.00x invariant, -0.06ms (-0.73d, 0.20p, 0.08std)
CairoMakie 3.04s (3.02, 3.07) 0.02+- 321.26ms (316.38, 325.94) 3.81+- 140.95ms (139.13, 144.72) 2.28+- 7.27ms (7.15, 7.39) 0.08+- 603.75μs (597.24, 608.89) 4.20+-
master 3.05s (3.02, 3.08) 0.02+- 319.05ms (316.24, 326.43) 3.36+- 140.62ms (138.58, 142.09) 1.25+- 7.36ms (7.27, 7.66) 0.13+- 604.87μs (600.62, 612.74) 4.04+-
evaluation 1.00x invariant, -0.01s (-0.47d, 0.40p, 0.02std) 0.99x invariant, 2.2ms (0.61d, 0.27p, 3.58std) 1.00x invariant, 0.32ms (0.17d, 0.75p, 1.77std) 1.01x invariant, -0.1ms (-0.89d, 0.13p, 0.10std) 1.00x invariant, -1.12μs (-0.27d, 0.62p, 4.12std)
WGLMakie 3.74s (3.69, 3.81) 0.05+- 417.35ms (324.60, 541.97) 113.97+- 8.97s (8.90, 9.06) 0.05+- 9.25ms (9.09, 9.33) 0.09+- 72.33ms (67.56, 76.91) 3.70+-
master 3.73s (3.68, 3.79) 0.04+- 421.50ms (324.07, 554.82) 117.18+- 9.08s (8.92, 9.23) 0.13+- 9.46ms (9.17, 10.56) 0.49+- 74.16ms (68.84, 81.12) 4.90+-
evaluation 1.00x invariant, 0.01s (0.30d, 0.59p, 0.04std) 1.01x invariant, -4.15ms (-0.04d, 0.95p, 115.58std) 1.01x invariant, -0.11s (-1.17d, 0.06p, 0.09std) 1.02x invariant, -0.21ms (-0.60d, 0.30p, 0.29std) 1.03x invariant, -1.83ms (-0.42d, 0.45p, 4.30std)

@jkrumbiegel jkrumbiegel removed the skip-changelog Skips changelog enforcer label Feb 6, 2024
@jkrumbiegel jkrumbiegel merged commit 8347d7a into master Feb 6, 2024
18 checks passed
@jkrumbiegel jkrumbiegel deleted the jk/enforce-changelog branch February 6, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants