Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented / validated plot attributes #3626

Merged
merged 112 commits into from
Mar 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
112 commits
Select commit Hold shift + click to select a range
d177b88
add second `@recipe` method
jkrumbiegel Feb 13, 2024
8157551
rename function
jkrumbiegel Feb 13, 2024
edd6236
implement recipe and keyword validation
jkrumbiegel Feb 13, 2024
1bc7031
fix some bugs
jkrumbiegel Feb 13, 2024
8d275e8
rename for clarity
jkrumbiegel Feb 13, 2024
5101841
change Scatter recipe
jkrumbiegel Feb 13, 2024
5c3617c
use argument symbols correctly
jkrumbiegel Feb 13, 2024
385bfc9
change Lines
jkrumbiegel Feb 13, 2024
a753094
change linesegments
jkrumbiegel Feb 13, 2024
4003b07
do a bunch of plots more
jkrumbiegel Feb 13, 2024
47d9ad9
fix text bugs
jkrumbiegel Feb 13, 2024
8c0b2ad
splice in internal attribute after mesh creation
jkrumbiegel Feb 14, 2024
f00125b
add allowlist
jkrumbiegel Feb 14, 2024
e2e491d
fix text
jkrumbiegel Feb 14, 2024
23314e6
add attribute deprecation mechanism
jkrumbiegel Feb 14, 2024
f2906e2
add explanation
jkrumbiegel Feb 14, 2024
b2ff0bf
remove `text` for GLMakie
jkrumbiegel Feb 14, 2024
083b66f
fix contour volume attributes
jkrumbiegel Feb 14, 2024
3fe0f7f
add rasterize to allowlist
jkrumbiegel Feb 14, 2024
9fa64ef
add `enable_depth` to volume
jkrumbiegel Feb 14, 2024
812ce26
add `matcap` to mesh
jkrumbiegel Feb 14, 2024
b2886ce
set `fxaa = false` on scatter, lines, linesegments, text
jkrumbiegel Feb 14, 2024
a58d191
move fxaa after mixins
jkrumbiegel Feb 14, 2024
42ff5fb
fix keywords
jkrumbiegel Feb 14, 2024
0df0503
remove markersize attribute
jkrumbiegel Feb 14, 2024
5d0e437
remove invalid markersize
jkrumbiegel Feb 14, 2024
2d76684
add depthsorting to attributes for scatter
jkrumbiegel Feb 14, 2024
b60cd66
fix forwarded attributes
SimonDanisch Feb 14, 2024
8ac2421
add absorption to volume
jkrumbiegel Feb 14, 2024
46ee1d3
don't use `used_attributes` for datashader canvas convert
jkrumbiegel Feb 14, 2024
5104723
fix positional args
jkrumbiegel Feb 15, 2024
e541e43
image
jkrumbiegel Feb 15, 2024
a89cc54
add better printing and rudimentary tests
jkrumbiegel Feb 15, 2024
cc0f714
make allowlist a tuple for fewer allocations
jkrumbiegel Feb 16, 2024
f4833e4
attribute names tuple instead of set
jkrumbiegel Feb 16, 2024
49851e6
make deprecations also a tuple
jkrumbiegel Feb 16, 2024
e38536a
avoid intermediate vector to speed up attribute creation
jkrumbiegel Feb 16, 2024
5f6a960
apply same optimization to blocks
jkrumbiegel Feb 16, 2024
8e100af
implement mechanism to augment user docstring
jkrumbiegel Feb 18, 2024
06a8ef0
delete manually written out attribute docs
jkrumbiegel Feb 18, 2024
39cecb9
use funcsym in docstring
jkrumbiegel Feb 18, 2024
857524a
incorporate attribute docs into docstring again
jkrumbiegel Feb 18, 2024
3281470
use equal
jkrumbiegel Feb 18, 2024
37c0ccc
add changelog
jkrumbiegel Feb 19, 2024
741cd71
Merge branch 'master' into jk/documented-attributes
jkrumbiegel Feb 19, 2024
9f2de2a
Merge branch 'master' into jk/documented-attributes
SimonDanisch Feb 23, 2024
794d715
Merge branch 'breaking-0.21' into jk/documented-attributes
SimonDanisch Feb 23, 2024
180559c
Merge branch 'breaking-0.21' into jk/documented-attributes
SimonDanisch Feb 23, 2024
66f5aba
Merge branch 'breaking-0.21' into jk/documented-attributes
SimonDanisch Feb 23, 2024
5c7500a
Merge branch 'breaking-0.21' into jk/documented-attributes
SimonDanisch Feb 28, 2024
4b9d8c9
introduce `DocumentedAttributes` with macro
jkrumbiegel Mar 1, 2024
d614fd8
add function to access `DocumentedAttributes` of a recipe
jkrumbiegel Mar 1, 2024
8eb463b
fix module mutation problem for now
jkrumbiegel Mar 1, 2024
11bdfa5
move definition behind PlotType
jkrumbiegel Mar 1, 2024
4bac2f7
return Attributes instead of Dict
jkrumbiegel Mar 1, 2024
9add0da
convert wireframe recipe
jkrumbiegel Mar 1, 2024
5592d7b
close over reference
jkrumbiegel Mar 2, 2024
c5f73a9
don't include prereleases in benchmark, failed with 1.11 alpha
jkrumbiegel Mar 2, 2024
6c09ea5
stringify default expr
jkrumbiegel Mar 2, 2024
d717970
convert arrows
jkrumbiegel Mar 2, 2024
a81786c
add docs
jkrumbiegel Mar 2, 2024
c55c993
directly convert default exprs to strings
jkrumbiegel Mar 2, 2024
65b5634
convert ablines
jkrumbiegel Mar 2, 2024
bf86c39
print wrong attribute in red
jkrumbiegel Mar 2, 2024
99d886e
convert annotations
jkrumbiegel Mar 2, 2024
485a82d
convert arc
jkrumbiegel Mar 2, 2024
5595d49
remove attributes in arrows docstring
jkrumbiegel Mar 2, 2024
c678ab6
convert band
jkrumbiegel Mar 2, 2024
5643973
fix escaping issue
jkrumbiegel Mar 2, 2024
eb3afee
convert barplot
jkrumbiegel Mar 2, 2024
af698d1
convert bracket
jkrumbiegel Mar 2, 2024
1fb0f39
fix barplot usage in hist
jkrumbiegel Mar 2, 2024
315e161
convert contourf
jkrumbiegel Mar 2, 2024
f59799b
typo
jkrumbiegel Mar 2, 2024
0d93e33
convert contour
jkrumbiegel Mar 2, 2024
43f0915
fix waterfall
jkrumbiegel Mar 2, 2024
28ba536
comment out arrows test
jkrumbiegel Mar 3, 2024
a506157
convert datashader
jkrumbiegel Mar 3, 2024
6eaf4c5
convert errorbar and rangebar
jkrumbiegel Mar 3, 2024
e83a330
convert hvlines
jkrumbiegel Mar 3, 2024
ea06069
convert hvspan
jkrumbiegel Mar 3, 2024
c2c61e5
convert pie
jkrumbiegel Mar 3, 2024
8f87638
convert rainclouds
jkrumbiegel Mar 3, 2024
0baa663
convert scatterlines
jkrumbiegel Mar 3, 2024
f733fca
convert series
jkrumbiegel Mar 3, 2024
a9d5e51
convert spy
jkrumbiegel Mar 3, 2024
cb70f02
convert stairs
jkrumbiegel Mar 3, 2024
0d5c14c
convert stem
jkrumbiegel Mar 3, 2024
48c6659
convert streamplot
jkrumbiegel Mar 3, 2024
7b1c28d
convert timeseries
jkrumbiegel Mar 3, 2024
04b8053
convert tooltip
jkrumbiegel Mar 3, 2024
4d57766
convert tricontourf
jkrumbiegel Mar 3, 2024
36d3ec1
add transformation to allowlist
jkrumbiegel Mar 3, 2024
793b75d
convert triplot
jkrumbiegel Mar 3, 2024
ec62a56
convert volumeslices
jkrumbiegel Mar 3, 2024
5a1294c
convert voronoiplot
jkrumbiegel Mar 3, 2024
05782e5
convert waterfall
jkrumbiegel Mar 3, 2024
a923b2a
convert boxplot
jkrumbiegel Mar 3, 2024
661f8ac
convert crossbar
jkrumbiegel Mar 3, 2024
fdd5645
convert density
jkrumbiegel Mar 3, 2024
13566a4
convert qqplot and qqnorm
jkrumbiegel Mar 3, 2024
c57f4d1
convert ecdfplot
jkrumbiegel Mar 3, 2024
422f2e3
convert hexbin
jkrumbiegel Mar 3, 2024
bbdab83
convert hist
jkrumbiegel Mar 3, 2024
8b081a6
convert violin
jkrumbiegel Mar 3, 2024
97ef4dc
improve error message printing
jkrumbiegel Mar 4, 2024
2b6fb21
add docstrings for mutating functions and plot types
jkrumbiegel Mar 4, 2024
c521e83
add missing docstrings
SimonDanisch Mar 5, 2024
a54da66
reconnect lines docstring
jkrumbiegel Mar 5, 2024
1d7b844
move functions out of macro
jkrumbiegel Mar 5, 2024
9a45530
fix arrows example and adjust docs
jkrumbiegel Mar 5, 2024
098a20c
put necessary functions back into macro
jkrumbiegel Mar 5, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/compilation-benchmark.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- uses: julia-actions/setup-julia@v1
with:
version: '1'
include-all-prereleases: true
# include-all-prereleases: true
arch: x64
- uses: julia-actions/cache@v1
- name: Benchmark
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## [Unreleased]

- **Breaking (sort of)** Added a new `@recipe` variant which allows documenting attributes directly where they are defined and validating that all attributes are known whenever a plot is created. This is not breaking in the sense that the API changes, but user code is likely to break because of misspelled attribute names etc. that have so far gone unnoticed.
- **Breaking** Reworked line shaders in GLMakie and WGLMakie [#3558](https://github.com/MakieOrg/Makie.jl/pull/3558)
- GLMakie: Removed support for per point linewidths
- GLMakie: Adjusted dots (e.g. with `linestyle = :dot`) to bend across a joint
Expand Down
1 change: 1 addition & 0 deletions GLMakie/src/GLAbstraction/GLTypes.jl
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,7 @@ function RenderObject(
try
data[k] = gl_convert(v)
catch e
@error "gl_convert for key `$k` failed"
rethrow(e)
end

Expand Down
Loading
Loading