[WIP] Better handling for missing
in colors
#3857
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to support users passing
Array{Union{Missing, <: Number}}
to a plot'scolor
argument in all circumstances. The usecase is passing vectors from DataFrames straight tocolor
- in many cases, this fails because the vectors have missing values, which then have to be changed manually (which is a chore!)Changes are:
numbers_to_colors
to pass missings through, and use the nan color to represent them.replace(color_array, missing => NaN)
when presented with such an array inassemble_colors
calculated_color
instead of relying oncolor
.Type of change
Delete options that do not apply:
Checklist