Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't remove underlying VideoStream file when doing save() #3883

Merged
merged 5 commits into from
Aug 9, 2024

Conversation

aplavin
Copy link
Contributor

@aplavin aplavin commented May 23, 2024

Description

For some reason, the file was removed when calling save(path, ::VideoStream). This breaks all following show calls: they, clearly, rely on the video file still being present.

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)

@SimonDanisch
Copy link
Member

Hm, that was a lazy clean up, assuming that one records a video and then when saving it, it isn't needed anymore.
I think we'll need to move this into a finalizer for VideoStream to not have this accumulate.

@aplavin
Copy link
Contributor Author

aplavin commented May 24, 2024

Hm, I don't think Julia has finalizers for regular structs... Should we make it mutable struct then?

@SimonDanisch
Copy link
Member

Yes, I guess we'll need to do that then ;)

@aplavin
Copy link
Contributor Author

aplavin commented Aug 1, 2024

bump...
would be nice to fix this

@ffreyer ffreyer mentioned this pull request Aug 8, 2024
5 tasks
@SimonDanisch SimonDanisch merged commit c4dd08d into MakieOrg:master Aug 9, 2024
18 checks passed
@SimonDanisch
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants