Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DataInspector using invalid attribute strokewidth for plot type Wireframe #3917

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Fix DataInspector using invalid attribute strokewidth for plot type Wireframe #3917

merged 3 commits into from
Jul 2, 2024

Conversation

jaakkor2
Copy link
Contributor

Description

Fixes #3912

wireframe! used attribute strokewidth that should have been linewidth

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@jaakkor2
Copy link
Contributor Author

@jaakkor2
Copy link
Contributor Author

Gentle ping @SimonDanisch

@SimonDanisch
Copy link
Member

Sorry we can't just merge breaking changes like this... Maybe we can make it non breaking for now? There's some machinery for that in recipes.jl

@jaakkor2
Copy link
Contributor Author

Uh, I am lost, neither in v0.20 nor v0.21 strokewidth was an attribute for wireframe, but on v0.21 error is shown for invalid attributes. This is a bugfix for DataInspector.

@ffreyer
Copy link
Collaborator

ffreyer commented Jun 29, 2024

Oh, this is just about a call to wireframe. I thought it was about renaming an attribute in the recipe, which would be breaking. This should be fine to merge after adding an entry to https://github.com/MakieOrg/Makie.jl/blob/master/CHANGELOG.md

@jaakkor2 jaakkor2 changed the title wireframe strokewidth should be linewidth Fix DataInspector using invalid attribute strokewidth for plot type Wireframe Jun 30, 2024
@SimonDanisch
Copy link
Member

Thanks! :)
CI is failing because of #4003

@SimonDanisch SimonDanisch merged commit 36f4397 into MakieOrg:master Jul 2, 2024
12 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid attribute strokewidth for plot type Wireframe, Makie v0.21.2
3 participants