Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DataInspector using invalid attribute strokewidth for plot type Wireframe #3917

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Fix DataInspector using invalid attribute strokewidth for plot type Wireframe #3917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cef6da9
wireframe strokewidth should be linewidth
jaakkor2 May 30, 2024
6fd0e9b
Update CHANGELOG.md
jaakkor2 Jun 30, 2024
b9f19b4
Merge branch 'master' into wireframelinewidth
jaakkor2 Jun 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
- Fix stack overflows when using `markerspace = :data` with `scatter` [#3960](https://github.com/MakieOrg/Makie.jl/issues/3960).
- CairoMakie: Fix broken SVGs when using non-interpolated image primitives, for example Colorbars, with recent Cairo versions [#3967](https://github.com/MakieOrg/Makie.jl/pull/3967).
- CairoMakie: Add argument `pdf_version` to restrict the PDF version when saving a figure as a PDF [#3845](https://github.com/MakieOrg/Makie.jl/pull/3845).
- Fix DataInspector using invalid attribute strokewidth for plot type Wireframe [#3917](https://github.com/MakieOrg/Makie.jl/pull/3917).
- CairoMakie: Fix incorrect scaling factor for SVGs with Cairo_jll 1.18 [#3964](https://github.com/MakieOrg/Makie.jl/pull/3964).
- Fixed use of Textbox from Bonito [#3924](https://github.com/MakieOrg/Makie.jl/pull/3924)

Expand Down
2 changes: 1 addition & 1 deletion src/interaction/inspector.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -827,7 +827,7 @@ function show_data(inspector::DataInspector, plot::BarPlot, idx)
clear_temporary_plots!(inspector, plot)
p = wireframe!(
scene, bbox, model = model, color = a.indicator_color,
strokewidth = a.indicator_linewidth, linestyle = a.indicator_linestyle,
linewidth = a.indicator_linewidth, linestyle = a.indicator_linestyle,
visible = a.indicator_visible, inspectable = false
)
translate!(p, Vec3f(0, 0, a.depth[]))
Expand Down
Loading